Date: Fri, 15 May 2026 14:03:02 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Sami Imseih <samimseih@gmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, Michael Paquier
 <michael@paquier.xyz>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Track skipped tables during autovacuum and autoanalyze
Message-Id: <20260515140302.5a532dfa246817a0b28854f7@sraoss.co.jp>
In-Reply-To: 
 <CAA5RZ0v-xJ5fdTvNOdfokbY10pjjP=x_sfQ6Td30bbooomysaw@mail.gmail.com>
References: <20260324151133.7940a5c1f2ebd594d54da481@sraoss.co.jp>
	<CAA5RZ0snnePNW1NKGKh+NyJ1CY26T5F_6-tTq+BHWM2kj1fN1g@mail.gmail.com>
	<20260325012847.e026ba1860c07288efe3e97d@sraoss.co.jp>
	<20260326192203.e6dbb8d80f8d27dc15ceee59@sraoss.co.jp>
	<acW8MW-Gb8Aj_TH2@paquier.xyz>
	<20260327163549.b5df519c0099970ddbb3412d@sraoss.co.jp>
	<CAA5RZ0tNh03LLgJVMA=PXSdY8YVoui4_GyfbfTrYK5cka3Q9Rw@mail.gmail.com>
	<20260328161802.f35b5a3e739566ffd7c1053b@sraoss.co.jp>
	<20260413170551.5ec43ba5a2c848f0d46c6a0b@sraoss.co.jp>
	<CAA5RZ0tUHU-r=Tc47P2DZyytF7x5h5OwBiRABe_dZt+zWNqe9g@mail.gmail.com>
	<20260427203207.32aa6ca37f2a18a05508dfda@sraoss.co.jp>
	<CAA5RZ0vwgXZ5kF2GvYBR+Ma1LPSbDjE9pjANzSiUw3wmpv51PQ@mail.gmail.com>
	<CAN4CZFO5BAr2uP=2CDDyX5ydFw8Ku=wtJ0ZtfLTKuWvXH6J2yQ@mail.gmail.com>
	<CAA5RZ0v-xJ5fdTvNOdfokbY10pjjP=x_sfQ6Td30bbooomysaw@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?hKclz6vTgxFci02fLI4dxv2BvaQETgvF5W0gh6jdmVtSlCj56fR3Uz9Osjlh?=
 =?us-ascii?Q?BYokHM9ts+zXkKApfA74vOQh0Wv+eIOHYxQoRSzHAZMT0w2tP5E0GK+EiTbk?=
 =?us-ascii?Q?AdMy6DYg/mkxX6ubzTjR/mqMw/WHdeAMtaQh2F2TAlgGHRI138cNVcrCS2N1?=
 =?us-ascii?Q?JXGNAehHvPkxJgFejGgJjSDSxx2zhG2rSBooTvXgpoDaVHQqAq0fZ8d6UiR9?=
 =?us-ascii?Q?tLxqT+Pk1SiMjQavYFZ+Clbje03J6r/t9/yLd/iA7fuQhOUtwNZXTlrJ21kp?=
 =?us-ascii?Q?dBjNLCshQe1ZF3iXT4ChWmNO0U80sz3+1lO7MOavuPXovbLpHU5B9xqAV39S?=
 =?us-ascii?Q?hp2+l3KOLNb+Rkkik0go5nN1+TGarQf54nRf1jfmejDc2aE5tMAxiIFT/go4?=
 =?us-ascii?Q?ZBlh76cqbvi3M7wRNQpyF1pFOmOgh5i3Hffz9bq0N0rgiTdFzb2we4bG+eq9?=
 =?us-ascii?Q?0WaNg8CFwM6+uIgnKp++exGAM8L+wDm/V8AJ5n3506b0rffrgnBqXx5NPQV+?=
 =?us-ascii?Q?uhACbxXgXHpfDLa8Bs2nbiQq2gqJ2nzU8o+pq+hD8McKY/kKm+chgRiNyglm?=
 =?us-ascii?Q?9SD3/NJB75PS+nbYAFhgJNKneUq4o33/fUtkgfpAT6D7tH84ni/f4rTvMB6w?=
 =?us-ascii?Q?108FflujO3v2kLBx3UjkzJStIMf65Z2or/jbn/Vxq2xufR/V5bXZBIqSuMWl?=
 =?us-ascii?Q?aU48sj+07bp0lOcwlhV0hJtf37NPVpYkp6sxKARv+XySyUehL/NzrpzgzsUw?=
 =?us-ascii?Q?tY4Bjdl5FXlOVqigjt+EISvl4xqrxmCql57Z3tQawhE0xiahwIz2Hk/D6l2y?=
 =?us-ascii?Q?YrHMZzgahmQU2Q4VEMKwjZ9UBxBK566KjBSH98efwpu/M1lNfzeyV892hZeX?=
 =?us-ascii?Q?kzdHXd8QsyQJFeJ6gYHO+Kw+DMzQpd6XWJMFlc6uehpEK3eUO1t9nf+tqTHE?=
 =?us-ascii?Q?Bgd8/IPLjHIJiPGBSxEO2nIHbBWuoxqF29Q7pohmMg0oaSNb+3OtVH3wdJQZ?=
 =?us-ascii?Q?w4/ausyaThbOspaIjfqfGOwh2+XAkOE8FdC22Sk/qH3yVb/NYTCoutrAjuVu?=
 =?us-ascii?Q?eZuC/Fb1qndF2LiFsT8Rvce7Q3COlEdgrqH4txa6xDN/16R8LqHxnxpfdOEl?=
 =?us-ascii?Q?hrDnS05HYhUkufXStqUuYpv+GgN0wapynJCv5JCkbDhqYYXnIbibCVCsfJ4/?=
 =?us-ascii?Q?cR2mB7tN7nZRogBMtpvPJY9szc2XkU4zXTl1b9AljcWV7NW1/Lqrax2fPF/N?=
 =?us-ascii?Q?HnWt0CKrw/1GC/1BjDIvXLkoIxNJr5ePYMJcw92gkPXht4g3pwzAvoOBBrEZ?=
 =?us-ascii?Q?6SgOsdpSIyGbbgiS1fkwf4axkHWYNsysW/+c0ODt322JfxVG5jROZ0GpIbNq?=
 =?us-ascii?Q?0SFzUx7HtisZSNyicMODq+nvfPCipRXtKW2gQeFJLaRt4QkMXNl0rqZCFdn0?=
 =?us-ascii?Q?HdbAEqHtdWqJpsVJJU0gZ0EqtYzm4GtYPY1DTtcUJXxv+qnrHA79ECQTqeCZ?=
 =?us-ascii?Q?y+ZQCQUNYzKNEERYzgYxHAU3EzXV/nMHww0yH0CUeIifkPU8JeIoKyCgg7TO?=
 =?us-ascii?Q?D++qvnqAbazKxjWJEcwl3P1oMfPiypbhWsJSQMfI0KwLC0JQwFnQH0FnYsbj?=
 =?us-ascii?Q?6W+lQ2q6uPxp2Y0Q832F9uDIwQSODfqLm/V7tU3LKcZW3lddGEd9bxSy4Xgf?=
 =?us-ascii?Q?e7qmi2ragTMvzi7ZG6l4a+Wwk44fFnCJdAMjr9BgzZBhELIZ2RCzO6SDpz2v?=
 =?us-ascii?Q?PFRys9rsvyqReaQP6ALhZy6K7cL7Q9IPACwnN2F9mTmGYs7NTz80CYPqL989?=
X-MS-Exchange-AntiSpam-MessageData-1: A0wrzzQoaczpRg==
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 8f12492d-5173-4e0b-2f6b-08deb23f3dfc
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2026 05:03:02.7337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 1ROWGetT7jat2Vl4CAJMWqGv9K0Um+BVs62HLhtP1dEmRdPKyUYghbLK/9vK0hTJLoYHvt5EW56E3rgnXsHUpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS7P286MB6842
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20260515140302.5a532dfa246817a0b28854f7%40sraoss.co.jp>
Precedence: bulk

On Thu, 14 May 2026 19:59:18 -0500
Sami Imseih <samimseih@gmail.com> wrote:

> > Doesn't these also require a PGSTAT_FILE_FORMAT_ID change?
> 
> right. that was missed. Fixed in the attached.

Thank you for updating the patch.

> 
> > There's also an asymmetric case for the skipped counters, is that intentional?
> >
> > | Command                                 | `skipped_vacuum_count` |
> > `skipped_analyze_count` |
> > |-----------------------------------------|------------------------|-------------------------|
> > | `VACUUM (FULL, ANALYZE, SKIP_LOCKED) t` | 0                      | 1
> >                       |
> > | `VACUUM (ANALYZE, SKIP_LOCKED) t`       | 1                      | 1
> >                       |
> > | `VACUUM (FULL, SKIP_LOCKED) t`          | 0                      | 0
> 
> Yeah, this is because vacuum_count and last_vacuum also skip VACUUM FULL.
> That was mentioned earlier in the thread.

Right.
 
> > > Initially, I was concerned that something might go wrong if a concurrent
> > > session performed DROP TABLE or ALTER TABLE RENAME between RangeVarGetRelidExtended()
> > > and RangeVarGetRelid(), but I could not find any actual issue. Even when the table
> > > name is changed, the correct statistics entry is updated correctly.
> >
> > A DROP TABLE can cause a missed skip in statistics, which is
> > reproducible with a custom injection point and tap test, see the
> > attached patch. The race window is quite minimal, but it exists.
> 
> If the table is dropped, there are no stats to update. right?

In my analysis, even if the table is dropped or renamed just before calling RangeVarGetRelid()
(at the injection point you added), RangeVarGetRelid() still returns the table's OID. So it
seems possible that the statistics entry is updated locally, but it would be released shortly
afterward and thus eventually becomes invisible.

However, I'm not entirely sure whether this behavior is always guaranteed.
Could anyone clarify this?

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>