public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yugo Nagata <[email protected]>
To: Pgsql Hackers <[email protected]>
Subject: A trivial fix on a comment in pgstat_assoc_relation()
Date: Fri, 15 May 2026 15:09:41 +0900
Message-ID: <[email protected]> (raw)
Hi,
I noticed that a comment in pgstat_assoc_relation() starts with "Else":
/* Else find or make the PgStat_TableStatus entry, and update link */
This seems to be a vestige from when this function was split out from pgstat_init_relation()
by commit 5891c7a8ed8f, so I think we could simply remove the "Else".
Regards,
Yugo Nagata
--
Yugo Nagata <[email protected]>
Attachments:
[text/x-diff] fix_comment_in_pgstat_assoc_relation.patch (625B, 2-fix_comment_in_pgstat_assoc_relation.patch)
download | inline diff:
diff --git a/src/backend/utils/activity/pgstat_relation.c b/src/backend/utils/activity/pgstat_relation.c
index b2ca28f83ba..04f2eb21d0b 100644
--- a/src/backend/utils/activity/pgstat_relation.c
+++ b/src/backend/utils/activity/pgstat_relation.c
@@ -134,7 +134,7 @@ pgstat_assoc_relation(Relation rel)
Assert(rel->pgstat_enabled);
Assert(rel->pgstat_info == NULL);
- /* Else find or make the PgStat_TableStatus entry, and update link */
+ /* find or make the PgStat_TableStatus entry, and update link */
rel->pgstat_info = pgstat_prep_relation_pending(RelationGetRelid(rel),
rel->rd_rel->relisshared);
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: A trivial fix on a comment in pgstat_assoc_relation()
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox