Date: Wed, 27 May 2026 11:49:06 +0900 (JST)
Message-Id: <20260527.114906.572152352039267184.ishii@postgresql.org>
To: assam258@gmail.com
Cc: jian.universality@gmail.com, zsolt.parragi@percona.com,
 sjjang112233@gmail.com, vik@postgresfriends.org, er@xs4all.nl,
 jacob.champion@enterprisedb.com, david.g.johnston@gmail.com,
 peter@eisentraut.org, li.evan.chao@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Row pattern recognition
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CAAAe_zD7vCLCb+vxpO3P-NsDUZ=JcN8EGCV0dz0BNgBKsbOGcQ@mail.gmail.com>
References: <20260502.140304.670813149418899420.ishii@postgresql.org>
	<20260524.171139.1720602000749196206.ishii@postgresql.org>
	<CAAAe_zD7vCLCb+vxpO3P-NsDUZ=JcN8EGCV0dz0BNgBKsbOGcQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20260527.114906.572152352039267184.ishii%40postgresql.org>
Precedence: bulk

Hi Henson,

> Thanks for catching this. I applied the patch and the RPR regress passes
> cleanly. I also re-ran it with debug_raw_expression_coverage_test turned
> on (on an assert-enabled build), and the full regress is green as well.
> 
> One observation while testing: the GUC catches missing case handlers
> once the walker actually reaches a node, but it cannot flag a missing
> WALK on its own -- if no caller drives the walker into a subtree, the
> omission stays silent. So your inspection was the part that found the
> gap; the GUC just confirms the patch closes it. With the patch in, RPR
> raw subtrees are on the safety net for any future node-type additions.

Thanks for checking.

> I'll include the patch in v48 as nocfbot-0015. My suggestion would
> be to defer the fold until the jian-response patches (numbered from
> 0016 onward, which I'll be sending shortly) have also gone through a
> review round, so the whole bundle can land together in one pass.
> Patch attached below for convenience.

Sure. I will wait for your ready-to-go signal before creating the v48
pach set.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp