public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Sun, 31 May 2026 09:11:19 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAAe_zAH0MvP0TBmW3PTLeHjEpiyBz0473zJRM9pwLpseefMNw@mail.gmail.com>
References: <CAAAe_zDephfiDA_A3FN0hCymJRogEr=Rt3QoCTf4qMYDLk+xNA@mail.gmail.com>
	<CACJufxGX17thWuEOq1tM5xbRHz2HXm1asooZC3GV25MYGmYqLQ@mail.gmail.com>
	<CAAAe_zAH0MvP0TBmW3PTLeHjEpiyBz0473zJRM9pwLpseefMNw@mail.gmail.com>

Hi Henson, Jian,

>> In src/include/nodes/execnodes.h, we're adding quite a few fields to
>> WindowAggState that are only used for RPR queries.
>> Should we consolidate these fields behind a single pointer (named
>> RPRContext) to keep the WindowAggState size smaller for non-RPR
>> queries?
> 
> The size win is real -- it's roughly 450-500 bytes per WindowAggState
> that every non-RPR window query carries today. But it takes a wide
> code change to get there: it reshapes every RPR access path, a
> sizable (if mostly mechanical) diff across nodeWindowAgg.c,
> execRPR.c, and the explain side.
> 
> Tatsuo, as co-author -- do you want this in v48? If you do, I'll
> prepare the RPRContext consolidation as an incremental patch for you to
> fold into v48. It isn't blocking either way.

Basically I think Jian's idea is good. In addition to the size reason
above, we would have less code changes when we adapt existing R020
codes to R010.

However it will need a wide code change as Henson said. I would like
to focus on stabilizing our code for now. Therefore I would not want
the refactoring in v48.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

view thread (109+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox