Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wTfMN-000fvG-3C
	for pgsql-hackers@arkaria.postgresql.org;
	Sun, 31 May 2026 12:33:44 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wTfMM-007YwH-0I
	for pgsql-hackers@arkaria.postgresql.org;
	Sun, 31 May 2026 12:33:42 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ishii@postgresql.org>)
	id 1wTfML-007Yw9-2S
	for pgsql-hackers@lists.postgresql.org;
	Sun, 31 May 2026 12:33:42 +0000
Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <ishii@postgresql.org>)
	id 1wTfMH-00000000Pqc-27eO
	for pgsql-hackers@postgresql.org;
	Sun, 31 May 2026 12:33:41 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type:
	Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender
	:Reply-To:Content-ID:Content-Description;
	bh=g1AquaeO4fbOiziMJfx59zzBcP19Ypw9VrdjVgG0i9Q=; b=Ayvxw1JRkACqK+raJmfTyOpsMr
	KLigC16o7CWksp2yvJWJW7ROwTL1QccFcAtRFetE3h74GvuyJ2+ATuiZzqWi4/xF4hAmm1zDNdSIu
	yGV7dwkNJkgfbiu2kDFNziUq4EFXew0Vl/C9Y4ZmoxejcToaUepyeRoCcPhYD9rLY+tho4wMl0+8I
	iD/e/0DYvmx8ezmuzBvFET8bbxI84FWJfym3PPJp7u32ilgD/3t3WShyRd7iboe5cc1CVWYWBoMY1
	1+4qQ5KGzLvsj7nbxU9S4XszsUNHaXrg7Whr3AjVwSSB/gY/mJZgKUjq946jqD9+2V1Fd4knh4zLA
	c9DNF/ew==;
Received: from [2409:11:4120:300:848c:cdd7:9cea:8fb6] (helo=localhost)
	by meldrar.postgresql.org with esmtpsa  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ishii@postgresql.org>)
	id 1wTfM8-001Iem-2G;
	Sun, 31 May 2026 12:33:30 +0000
Date: Sun, 31 May 2026 21:33:13 +0900 (JST)
Message-Id: <20260531.213313.1224322053367141508.ishii@postgresql.org>
To: assam258@gmail.com
Cc: zsolt.parragi@percona.com, sjjang112233@gmail.com,
 vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com,
 david.g.johnston@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com,
 pgsql-hackers@postgresql.org
Subject: Re: Row pattern recognition
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20260502.140304.670813149418899420.ishii@postgresql.org>
References: <20260427.174220.1939160662649810289.ishii@postgresql.org>
	<CAAAe_zBdwAUDNs_WFdLkFF=ewhkDkv-AqizVEVzhsfremGFb4w@mail.gmail.com>
	<20260502.140304.670813149418899420.ishii@postgresql.org>
X-Mailer: Mew version 6.8 on Emacs 29.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for
 2409:11:4120:300:848c:cdd7:9cea:8fb6 (failed)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20260531.213313.1224322053367141508.ishii%40postgresql.org>
Precedence: bulk

Hi Henson,

> Attached is the v47 patches for Row pattern recognition (SQL/RPR).

I accidentaly noticed that v47-0002 changes findTargetlistEntrySQL99
from static to extern.

-static TargetEntry *findTargetlistEntrySQL99(ParseState *pstate, Node *node,
-											 List **tlist, ParseExprKind exprKind);

I think this is not necessary anymore since findTargetlistEntrySQL99
is not used outside parse_clause.c.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp