Date: Mon, 01 Jun 2026 14:49:22 +0900 (JST)
Message-Id: <20260601.144922.658666928129832364.horikyota.ntt@gmail.com>
To: shinsj4653@gmail.com
Cc: pgsql-hackers@lists.postgresql.org, wolakk@gmail.com,
 x4mmm@yandex-team.ru, andreas@proxel.se, nik@postgres.ai
Subject: Re: Add wait events for server logging destination writes
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: 
 <CACdN0M78U+GvpqA7oey-GA7fFSYM636aDp6H9FVvCztv9zXxSA@mail.gmail.com>
References: 
 <CACdN0M78U+GvpqA7oey-GA7fFSYM636aDp6H9FVvCztv9zXxSA@mail.gmail.com>
User-Agent: Mew version 6.8 on Emacs 29.4
Mime-Version: 1.0
Content-Type: Text/Plain; charset=euc-kr
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/20260601.144922.658666928129832364.horikyota.ntt%40gmail.com>
Precedence: bulk

Hello.

At Sun, 31 May 2026 17:50:08 +0900, 신성준 <shinsj4653@gmail.com> wrote in 
> Attached is a short series that adds two WaitEventIO events and reports
> them around those writes:
> 
>   IO / SysloggerWrite - write(2) to the syslogger pipe
>   IO / StderrWrite - write(2) to stderr, and WriteConsoleW()
> 
> 0001 adds the events and covers the write(2) paths. 0002 does the
> Windows WriteConsoleW() path, split out since it's platform-specific.

Should we also consider instrumenting ReportEventW()/ReportEventA()?
They seem to be another Windows-specific logging output path.

Also, if the intention is to cover all places where logging output can
block, I wonder whether the syslog() calls should be covered as
well. If they are intentionally excluded, perhaps a short comment
explaining the rationale would be useful.

Regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center