Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUHbu-0013ff-0G for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jun 2026 05:24:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wUHbs-00Cp5t-1T for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jun 2026 05:24:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUHbs-00Cp5l-0Y for pgsql-hackers@lists.postgresql.org; Tue, 02 Jun 2026 05:24:16 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wUHbp-00000000nSH-3aeJ for pgsql-hackers@postgresql.org; Tue, 02 Jun 2026 05:24:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type: Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender :Reply-To:Content-ID:Content-Description; bh=COQ3H3p0SFPauCuMaStSDYS7+suVHVFRmrk2XiojOG8=; b=3wEmOKScDFjP9dn8P3dN/4bdsL 1V2YujbUAQyQ1b2J5JMFECrmoKy7Hu0R1MMuNy8JIPJfPaPTGYCErlJpp9RstU7C4Ty0CFQZGUSOQ 7NdjdPebrVLVofzWGyhtpuFwHwyuDXB1OAmIyDMhWWKNQYQx7gXFYcTrk7Z8Q1Vxq9Xn/WlXcatsB 24tHuLKk4pQeBBePp4Fg6F1R+VoYo7AYU99e6T2VJzlGSk32rdtu8F21W1q7eOFIP4aOYf+MuU09+ eAa0KxaD6xgrXj/HhesqP6Kn/eoIUbm7CPjsCdqczCfsesQznlJ/AXsJntADJil1ZdY2P5SuQANZO m4z0/6aA==; Received: from [2409:11:4120:300:1328:9820:eeaa:af58] (helo=localhost) by meldrar.postgresql.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUHbi-001zO4-0T; Tue, 02 Jun 2026 05:24:08 +0000 Date: Tue, 02 Jun 2026 14:23:56 +0900 (JST) Message-Id: <20260602.142356.343550180613194547.ishii@postgresql.org> To: assam258@gmail.com Cc: jian.universality@gmail.com, zsolt.parragi@percona.com, sjjang112233@gmail.com, vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com, pgsql-hackers@postgresql.org Subject: Re: Row pattern recognition From: Tatsuo Ishii In-Reply-To: <20260602.142009.1903449512796629664.ishii@postgresql.org> References: <20260602.142009.1903449512796629664.ishii@postgresql.org> X-Mailer: Mew version 6.8 on Emacs 29.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:11:4120:300:1328:9820:eeaa:af58 (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Oops. > While looking into 0002, I noticed some minor ereport calling style > issues. > > Recently we start to use the style: > > ereport(ERROR, > errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > > Rather than (old style): > > ereport(ERROR, > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > > Grepping patches shows following results that hire the old style. > > $ grep -n '(errcode' *|grep '+' > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1243:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1248:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1421:+ (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1428:+ (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1451:+ (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1457:+ (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1463:+ (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1471:+ (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1494:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1504:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), These have been fixed in 0007. Sorry for noise. Maybe this is the only one worth to look into? > nocfbot-0025-Reject-single-row-window-frame-in-row-pattern-rec.txt:55:+ (errcode(ERRCODE_WINDOWING_ERROR), Regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp