Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wUMDm-0016Xi-2U
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 02 Jun 2026 10:19:43 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wUMDl-00EA3W-1s
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 02 Jun 2026 10:19:41 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ishii@postgresql.org>)
	id 1wUMDl-00EA3O-0j
	for pgsql-hackers@lists.postgresql.org;
	Tue, 02 Jun 2026 10:19:41 +0000
Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <ishii@postgresql.org>)
	id 1wUMDi-00000000ptT-36ms
	for pgsql-hackers@postgresql.org;
	Tue, 02 Jun 2026 10:19:40 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type:
	Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender
	:Reply-To:Content-ID:Content-Description;
	bh=eY2trYhEAmLh8IbrKZ2gMV03uQxp7FGW7uxFsX9wG5Y=; b=tCWDgwG9cLvq3XlcOTbTMXo9iW
	p5oCzcczWmxZ3DS6U9ciPvr9fzz2u7oqX6CP1LNEpARkd8Q/3J4eWGawZ9WeM5256GaO4AR/HBI7M
	BCmksumc3XlbBlgDET2OafJYfRtv4YTN7bVRNUxZtxaqrQgqL6YbbjS4hszxf04F8qF+PraHyJ6Dp
	W6CmDsgaSyRy4CZP3NI+nEbn2OGjIhQfKgZG1dRu7Do8SalMiPILMfTG3mHbJs4z+0m7EyU2JVCdg
	2cArL4P5L4wReAefL9g8l/sqkFHMBgQCVqOpQvCQO4iMcx908iN+VehT2VATDIgO5IEmeId+I7B4J
	ufZZwl2w==;
Received: from [2409:11:4120:300:af7:f2:dbeb:7e11] (helo=localhost)
	by meldrar.postgresql.org with esmtpsa  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ishii@postgresql.org>)
	id 1wUMDa-00248w-1N;
	Tue, 02 Jun 2026 10:19:32 +0000
Date: Tue, 02 Jun 2026 19:19:12 +0900 (JST)
Message-Id: <20260602.191912.1197273977474107705.ishii@postgresql.org>
To: assam258@gmail.com
Cc: jian.universality@gmail.com, zsolt.parragi@percona.com,
 sjjang112233@gmail.com, vik@postgresfriends.org, er@xs4all.nl,
 jacob.champion@enterprisedb.com, david.g.johnston@gmail.com,
 peter@eisentraut.org, li.evan.chao@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Row pattern recognition
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20260602.142356.343550180613194547.ishii@postgresql.org>
References: 
 <CAAAe_zAuHwqUfqJOD4PDUkWsxTfTytNaandq11Kddw2bfCcpvQ@mail.gmail.com>
	<20260602.142009.1903449512796629664.ishii@postgresql.org>
	<20260602.142356.343550180613194547.ishii@postgresql.org>
X-Mailer: Mew version 6.8 on Emacs 29.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for
 2409:11:4120:300:af7:f2:dbeb:7e11 (failed)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20260602.191912.1197273977474107705.ishii%40postgresql.org>
Precedence: bulk

Hi Henson,

In execRPR.c:

static void
nfa_reevaluate_dependent_vars(WindowAggState *winstate, RPRNFAContext *ctx,
							  int64 currentPos)

This function does not have a forward declaration. Moreover, it is put
in the "API exposed to nodeWindowAgg.c" section. If there's no
particular reason for this, I suggest to add a forward declaration for
it and move it before "API exposed to nodeWindowAgg.c" section.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp