Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wUXc6-001EmJ-3C
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 02 Jun 2026 22:29:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wUXc5-00GFSS-2n
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 02 Jun 2026 22:29:33 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <andrey.cherny@tantorlabs.com>)
	id 1wUXc5-00GFSJ-0y
	for pgsql-hackers@lists.postgresql.org;
	Tue, 02 Jun 2026 22:29:33 +0000
Received: from forward500a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:d500])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <andrey.cherny@tantorlabs.com>)
	id 1wUXc3-00000000wMr-0UPT
	for pgsql-hackers@lists.postgresql.org;
	Tue, 02 Jun 2026 22:29:33 +0000
Received: from mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net
 (mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net
 [IPv6:2a02:6b8:c22:d15:0:640:87c2:0])
	by forward500a.mail.yandex.net (Yandex) with ESMTPS id 3F275C1503;
	Wed, 03 Jun 2026 01:29:29 +0300 (MSK)
Received: by mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net (smtp)
 with ESMTPSA id SToVRHOgJuQ0-j3ywkKXb;
	Wed, 03 Jun 2026 01:29:28 +0300
X-Yandex-Fwd: 1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tantorlabs.com;
	s=mail; t=1780439368;
	bh=pHcvR//1CKErtoTG/kH9X88a0sM3b6Y8MnOyna2ySvk=;
	h=Cc:Message-ID:Subject:Date:References:To:From:In-Reply-To;
	b=o8TCdNJe7RyBpn5CvOzsLKpW+nvRb6/5FFTUJ0/rBj7TKohYVStw2/aKuOR1b0wqI
	 eEiu0m8S+zSgcwb5RKke+FYPmyYoRAR73MT41cl7zHyx9nyt1f5ahrJD4UnPnuctPW
	 Bbun8a2/vXQBPByRaeW9zIJ+purbOcMN+m0BmHM8=
Authentication-Results: 
 mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net;
 dkim=pass header.i=@tantorlabs.com
Date: Wed, 3 Jun 2026 01:29:27 +0300
From: Andrey Chernyy <andrey.cherny@tantorlabs.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Fix libxml leaks in contrib/xml2 XPath functions
Message-ID: <20260603012745.14262e5b@andrnote>
In-Reply-To: <ah9Uz-VwT9H_lpvG@paquier.xyz>
References: <20260601010124.5edf9a20@andrnote>
	<ah0E0xLvv5_OtOi6@paquier.xyz>
	<20260602034314.7eadc4d7@andrnote>
	<ah9Uz-VwT9H_lpvG@paquier.xyz>
X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20260603012745.14262e5b%40andrnote>
Precedence: bulk

Thanks, Michael.

Agreed about xmlXPathCompiledEval(); without a reliable error indication
from libxml2, xml2 cannot distinguish a valid NULL result from an
internal failure locally.

The v2-0001..v2-0004 merge sounds good to me.

--
Andrey Chernyy