Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWRRo-002cFM-36 for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jun 2026 04:18:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wWRRm-000aAB-2D for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jun 2026 04:18:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWRRm-000aA1-1I for pgsql-hackers@lists.postgresql.org; Mon, 08 Jun 2026 04:18:46 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wWRRk-00000001dAK-23fb for pgsql-hackers@lists.postgresql.org; Mon, 08 Jun 2026 04:18:45 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-c85b2139015so1204057a12.2 for ; Sun, 07 Jun 2026 21:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780892323; x=1781497123; darn=lists.postgresql.org; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=sml2oEhgCb7V+3EG65/OdmVXKkzh6FUtKdL+/ebN2b8=; b=Pt2sD9U7IsBxudTYpMvhhksO3sZjRlIPAI0qzunZ3rj7l4+UiATZdsPB3MEwoEXjMk YnT8FdBvskPf23xqWS7RweUSsvae0kBKi0tXwoxwVb8dxOzxT5cxI8QCceb6p8TUQjBT CQPJXRoZCFIV186seTbtf48pK4TtJPxilNBxwwKRibP+gMgrsh/eVMvM2QEJ8fhiQ+zG wL/s7fpydhStafnbIzCdNDxzXOAJAoR9m7BVU8/CLrZkhuuZ792X5TRlKmuPxPjkUg9X ymSBtCnh9QrI5FPlFNq0f4ExkBx4NOdvo+dz5sZpyIWapjelS2yDId6pLFD8vKw6x2pY rzVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780892323; x=1781497123; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sml2oEhgCb7V+3EG65/OdmVXKkzh6FUtKdL+/ebN2b8=; b=pExmKs9klvQXN/OTLCa0uEREhAOFlGUIXPu/B3fnGf87ECM0I5MCuxQWAbRJO12+/B ZlJbQbKvV8mdFU4eyzlYi4rSSKP7MGviXD03QWSmq8u8qeaJvPdaGAXgE+M9f/1WzreK 9/w2MoGewfqh5iIn+zjZNsDHt9R1at1zS3BlR1mHvD6ceHz69/iRiGaZJ9DvBl7RAdX7 m9Os4UvbnXFTbuBr/Rp1b5l65MJS6/3UWqes7rvXOQrTTJwFt+JIUDdzNRKPCrj5GC9/ +7Gx3eSewD9OseQfLBe5QVr53kfLdtlmkCGja8yGY+0kfIFvO9daxbEs3UmmlYnlHque pyug== X-Gm-Message-State: AOJu0YwTMOVcVjMRKsts00eQyV7oql6djF+JS0yGcEks1VG56/9TOU3Z 3IPI40AbjOtlW3bu444lXBagsVHAvxOo353eIKBJp7fL0GpWYuVgicKl X-Gm-Gg: Acq92OHtrlSyklaYrgJIvLsjXn2eZEQiYZ73KAIZSLVLtLOHAwVEUHz/JiAQ6HZ19hj 8UASEhQJzproSVLqNZhKWsMvI7XqEr4SEBLFGDKm33h+CL+YAPmFi8FIwjfOQQt0d0MdOmtGaW4 s3W1WATaRS7D9W4WIwfpqNMMvAzh8CqJLo7Dq2kfX8fPoaWifi4y2W+IRjp5G/Pks/ddx/aox4c 7vIZY+4xlKrH1zbsM/Cb/qqPw2Rg0BOKesFtI7bg2qbxUCF4h1h5TbWpKLHFgD6tHvacAoKI/Yc j/FKg38TzYJ2nxSfkhbS+yIMpFZDM0s+RN0S9PsWucehfFjLxGbIwsuwIL+5Jz7m+LyknR0D5rK YMolWCIZI6gM6Dyo8joVdACA5I1yzeDea5pOnDhFkGM9EPDwcqNNiDLTTgM+S3oOTLoSKAGZ7Ts NenlOYfUDb7d5JHhTal1kdnkpsQf8hUAvcvgzdTLqg1zvsaHgsscGzD0q9adcdYLGiIXciC0YJd MVAvaJ36g== X-Received: by 2002:a05:6a21:4cc3:b0:398:9b42:69f7 with SMTP id adf61e73a8af0-3b4cd03dd7bmr14382237637.39.1780892323393; Sun, 07 Jun 2026 21:18:43 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df03387asm14935716a12.4.2026.06.07.21.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 21:18:42 -0700 (PDT) Date: Mon, 08 Jun 2026 13:18:41 +0900 (JST) Message-Id: <20260608.131841.1794193377521392131.horikyota.ntt@gmail.com> To: zakariyahali100@gmail.com Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Fix loose polling in 019_replslot_limit.pl test From: Kyotaro Horiguchi In-Reply-To: <20260606203222.108048-1-zakariyahali100@gmail.com> References: <20260606203222.108048-1-zakariyahali100@gmail.com> User-Agent: Mew version 6.8 on Emacs 29.4 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello. At Sat, 6 Jun 2026 21:32:22 +0100, Zakariyah Ali wrote in > -git a/src/test/recovery/t/019_replslot_limit.pl b/src/test/recovery/t/019_replslot_limit.pl > index a412faf51c6..3fdce739965 100644 > --- a/src/test/recovery/t/019_replslot_limit.pl > +++ b/src/test/recovery/t/019_replslot_limit.pl > @@ -186,18 +186,9 @@ $node_primary->advanc (Some explanation of the motivation would be helpful.) These are test scripts, so unless there is some functional issue with the existing code, I'm not sure we should actively replace existing implementations with wait_for_log(). In other words, I would normally expect this kind of change to happen only when the surrounding code is being modified for some functional reason. As for this patch specifically, there are still other places using open-coded log searches (for example, 033_replay_tsp_drops.pl). If we decide to make this kind of change, I think it would make more sense to update similar cases together. Regards. -- Kyotaro Horiguchi NTT Open Source Software Center