Date: Wed, 17 Jun 2026 14:59:52 -0700
From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: jian he <jian.universality@gmail.com>,
	Mahendra Singh Thalor <mahi6run@gmail.com>,
	tushar <tushar.ahuja@enterprisedb.com>,
	Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Non-text mode for pg_dumpall
Message-ID: <20260617215952.1f.noahmisch@microsoft.com>
References: 
 <CACJufxFs9NXXTeb78i2MD+pnZootayAtiGcNHNeU35SmQgMjbA@mail.gmail.com>
 <59d3616f-6d6d-40d5-87e2-e019e350b52d@dunslane.net>
 <CACJufxEnmJ8otfmN7Kp110Wqi=M4YE0-zn-W6SK+eTpWuZw_fg@mail.gmail.com>
 <CAKYtNAqxjQMLVPfz6XESqszhxZKgigi7UEBzBhz_Wj_Bnasdag@mail.gmail.com>
 <7faf3a59-cfe1-45cb-a972-55e05560b414@dunslane.net>
 <CACJufxE-zJiBAaZABtJBJr8FZdj=xP5adf_excmu9S6Op=KpLA@mail.gmail.com>
 <2e7ada75-422c-4153-9437-ea0ce8d63521@dunslane.net>
 <84764ef6-2bcb-43f7-9037-d7b589857da9@dunslane.net>
 <20260607000218.96.noahmisch@microsoft.com>
 <cfc6ae07-a161-4ada-bf8c-57eed960e5ff@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cfc6ae07-a161-4ada-bf8c-57eed960e5ff@dunslane.net>
User-Agent: Mutt/2.3.0 (2026-01-25)
Archived-At: 
 <https://www.postgresql.org/message-id/20260617215952.1f.noahmisch%40microsoft.com>
Precedence: bulk

On Mon, Jun 15, 2026 at 04:11:16PM -0400, Andrew Dunstan wrote:
> On 2026-06-06 Sa 8:02 PM, Noah Misch wrote:
> > On Thu, Feb 26, 2026 at 09:02:48AM -0500, Andrew Dunstan wrote:
> > > pushed with a slight tweak.
> > Having now reviewed commit 763aaa0, I don't think it's ready to remain part of
> > v19.  While some points from my v18 review are now resolved, other points
> > still seem unresolved.  I didn't find discussion of the unresolved points.  I
> > also see new issues.
> 
> OK, here's a reversion path. It's a bit messy, and I didn't touch the
> release notes, but apart from that I think it does the right thing.

I checked "git diff 763aaa06f03^ src/bin/pg_dump/{*.c,*.h,t}" and I agree this
reverts everything.  Thanks for working through the revert.