Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1waZez-001twG-09 for pgsql-hackers@arkaria.postgresql.org; Fri, 19 Jun 2026 13:53:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1waZex-00GUdE-26 for pgsql-hackers@arkaria.postgresql.org; Fri, 19 Jun 2026 13:53:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1waZex-00GUd6-16 for pgsql-hackers@lists.postgresql.org; Fri, 19 Jun 2026 13:53:27 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1waZeu-00000001HF8-3Jzh for pgsql-hackers@postgresql.org; Fri, 19 Jun 2026 13:53:26 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-490ac357c55so20769315e9.1 for ; Fri, 19 Jun 2026 06:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781877203; x=1782482003; darn=postgresql.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CLv/pmzKLtCSiSpetmqYtbTV+qGBYOcVe0wIWI27BPc=; b=g1Zpj4lMwx02anT48rMc6apOCbc6LA2TWm08S9vHS6OxMkihIo/xnI5gwNdQc6lHPE PR9Nbt5xAMk7xYyFLql9/OJ9L46PQZOKb20qorC/0EFqW9vQvm4UAH3D6aAVWjcv0pAp O6M0684+GwJ/wCVjw70olVc7W6cdFrIeOZiQMQ/C0m8ShNcAKI7OWF/IXtwvcHD+V8VY H0SQBnca/RUZ749M+p6muZGuVMV/p3vLKh9yxnGPjNu0DVX1EN82eW+l0h9DQvcT4TLy N+d8clEADAkw2WW4W7wmPTLLLYldvbEzgeiezTxwyqUwhD1E6f7JN+Gsbj1XTbD0O/Ud 2Fgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781877203; x=1782482003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CLv/pmzKLtCSiSpetmqYtbTV+qGBYOcVe0wIWI27BPc=; b=bScCvulMT5f8DTJDYsM0G0WoV5DlNcbzzxq4WTTGDByX7gkHnPNY4eYMR9/hvl3VMx gJKBE9olmiAsDrLxFXv3sD6uqW3EA9gqChIe36OwPWVveh1epJpFNvLq2A7DdrXN5uZ+ 3PGLR31ReOM+OuIVnklkjUB6ld20AniE45GplxxR0eM6GyzhlRvikvB9G3SHy4x6WH0Y WzZsmSDHM/k7px0aB2DfUL8ZYqJKqFn6uwvWxHmLYVf/1qt+NLiqkFYgugUiIrHYurfE 1zMIWVHzQAMfGEZpXup9d6nJoyzns5DhHO76Y5LxZvNT0y/3IkP6Iv5htRFPlhkFLNrP InhQ== X-Gm-Message-State: AOJu0YwgUWA2y106nOVpFjRb2rCxmAuFnB8BpC3/3AEbVulP3+8SwzcS pxoreJ2is9RzlKS8yOhaqTf+F+hhMDy4opDixyIBH9NY7qK8Zqo9dn4zaJqNI6uP X-Gm-Gg: AfdE7ckTtt7PhysYjMBQzsXZg9bOls352e98mv1vZI+EVDMfWrZt5g0ZJYUhAkUr7c9 uPTDHJTVfi5B8/bF4OZtFATg3je4IVPwaFt3dYm5T62/fxxfhj8pxPAmsfcEymqpm6qZeP+cxUM 1aoRM8SBberZMlQeM8K/qdrq+XIdyd4wDmGQfs9pyfaq5VDDKRSV1mYuR9vsJkcMg5yM7N+TdmC 91PyZsMk873GjOyyTClChSXZtyY5Wz6h8BIn7BTcgDtgHRriVsOWj1YyTdhHFGmkqK2RqAEyrNQ 16GL5GwQDbm4sc47xJs01Nt7L3KKu5GwfvN6DNAVPEyiTQFFk0PTcsZQTEJ0Fe+tGD5LcFGEw7S BK3OuqNFtXUuO9mTxna7+Qdiai7kme9bRSzC4kPm0GoUD7my46u+mr7GK9gB5zx3+s92wSJTzIW xG1ZeXOd2eIaPr3qUA4sxex06Tr94kr0JubjTmIg6E+YO/I+/1L8pKb3+9NlLcyQTzD0+AnhW+g Ilc X-Received: by 2002:a05:600c:4057:b0:490:9588:bdae with SMTP id 5b1f17b1804b1-49240e5b677mr46703295e9.18.1781877203038; Fri, 19 Jun 2026 06:53:23 -0700 (PDT) Received: from alibaba.. ([98.97.77.123]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd15535sm77741865e9.3.2026.06.19.06.53.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 06:53:22 -0700 (PDT) From: Zakariyah Ali To: Kyotaro Horiguchi Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH] Fix loose polling in 019_replslot_limit.pl test Date: Fri, 19 Jun 2026 14:52:57 +0100 Message-ID: <20260619135257.158592-1-zakariyahali100@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260606203222.108048-1-zakariyahali100@gmail.com> References: <20260606203222.108048-1-zakariyahali100@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Kyotaro, Thank you for the review and the helpful feedback. You are absolutely right that I should have included the motivation. The original intent was to reduce code duplication and use the existing `wait_for_log()` helper for better consistency in the test suite. I understand your concern about not touching functioning test code without a strong functional reason. Also, I agree with your point about inconsistency, leaving some tests using `wait_for_log()` while others (like `033_replay_tsp_drops.pl`) use open-coded log searches makes the codebase less uniform. To address this, I've decided to take the broader approach. I am currently reviewing the rest of the test suite to find similar open-coded usages. I will prepare and submit a v2 patch that standardizes all these instances to use `wait_for_log()` together. Thanks again for pointing me in the right direction. I'll follow up with the updated patch shortly. Best Regards, Zakariyah Ali.