Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1whb67-000Jkw-1U for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jul 2026 22:50:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1whb65-009snU-3D for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jul 2026 22:50:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1whb65-009snM-2L for pgsql-hackers@lists.postgresql.org; Wed, 08 Jul 2026 22:50:30 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1whb63-00000000MOf-3hHz for pgsql-hackers@postgresql.org; Wed, 08 Jul 2026 22:50:30 +0000 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-c96d2bebca3so202368a12.3 for ; Wed, 08 Jul 2026 15:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; t=1783551026; x=1784155826; darn=postgresql.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=JxvaRqxy7KyU2D6rd9rc7Fjjudhn+kFARNHqHhh+uY4=; b=ImnXzD05ZDQllaaznuKdUo/NFsrWX0uRKdr0Tvk2/D7Adx3r/1OtIT6rkXRxVounHJ ZBAdYRtdNOgoKaSjx281N8MQ2fK6YoMrHcXjFwPin+/XPxdO28dr/OmHOYxYeabf+Fb3 k4vq9BnqdqoUsM1DNFHB7LSz51Vdp68eyEk7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783551026; x=1784155826; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JxvaRqxy7KyU2D6rd9rc7Fjjudhn+kFARNHqHhh+uY4=; b=Zv07trVk1JAXYCE98leukV42NeW+ps//pvxhyOBPqw4Ckjiy5vlTrz8jOczRUGohKQ 3iSBpfUBKJ7D16jAfAlMfszI3M4ABxW1DAwXSuyo0luXoowVYKhXOVKYsof+A/MzF/NE dnludAYKqDHqEYEWkjA3pDjcgWpvDVPMHy6glgrVSFeGo2rdFr6a53gQ5V4FQdaRHyZJ wvG/MsbggV/fjqhNs4odghNX0Lq977Fi/PHyPowSM0qLnRqLF/OfZk+A+clx1zkU5XyL 6q7OPxg3q/4Cs/lEDEllL5TnaZBzUYMg50MJ6CDCk/rzFpWrVa3a2qx+u9P76nuZz1t0 G5EQ== X-Forwarded-Encrypted: i=1; AHgh+RqlyK7ehoVArBTTK+vplmwmwriaXxr0V4ua5OYIJWrIqFCSzgTgO0HFuW8fLD/L45rhUhRw1aiZtJ4vf3z8@postgresql.org X-Gm-Message-State: AOJu0YwMube2tOWzaadLH7QgAMg8+1OUcYY6xSKmRpbpVHVZPn+e8Inv JVvhmWTIW1ZTTL033heh2JXX7nXH6kdc628I6zDWTo0rYWET1naUKStaj8jwmD2wVesLTFkmk9M Jhqh+wg== X-Gm-Gg: AfdE7clqKHCIht/OPInUOSEl6Vrv2UX2geLuHcCfUtY7DAHWVY6NV4fwoLx66nfAHsL sq5PAKIPHq79i0e/qZlSwxFh0G4BVCb13wUV5ct9Js+PiN7M0rDeP+UOCWVONgnLCEWTccH/7Jz Q50BYdL0GXrKhvpgARGHUts7MAbMA89z89vS8Rb8VmAeTrJDP7I82k/4zoA4xEnxdYdKoQo1C/U 6M/YVHSHATrtkUNA8kIqLsaB8CrupojmVmXRJr2c4/2gemNOOsku1gGsLQCjxFo1ag2Jzz7uuev 9/9ROc+lwxCcpgIl2RzHUdQJSmPXECn6LoJiHOvawStCSRmbrQlXGmdxpGEL+32xzv/b9uE/sye JfFspBJMJPxb/VhovF7tYAOKj1lmhw3VsidXDN+gX8ohBRdmstaSt6ORy/pmIE/APMj4vPq//J4 0xDux1N24wIV67vQLOcTkSCPMgNaEOEYBN1+yNIzaamkkC X-Received: by 2002:a05:6a21:4910:b0:3bf:b08a:cded with SMTP id adf61e73a8af0-3c0bce9caf9mr5318968637.37.1783551026472; Wed, 08 Jul 2026 15:50:26 -0700 (PDT) Received: from microsoft.com (c-73-15-160-255.hsd1.ca.comcast.net. [73.15.160.255]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31198cb2b99sm6354900eec.26.2026.07.08.15.50.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2026 15:50:25 -0700 (PDT) Date: Wed, 8 Jul 2026 15:50:24 -0700 From: Noah Misch To: Alexander Korotkov Cc: d.koval@postgrespro.ru, pgsql-hackers@postgresql.org Subject: Re: SPLIT/MERGE use of is_internal=true Message-ID: <20260708225024.27.noahmisch@microsoft.com> References: <20260707185751.f9.noahmisch@microsoft.com> <20260707235839.5f.noahmisch@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.3.0 (2026-01-25) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jul 08, 2026 at 09:32:06PM +0300, Alexander Korotkov wrote: > The attached patch removes is_internal = true from 3 other function That covers all I saw. > calls, and removes PERFORM_DELETION_INTERNAL flag from > performDeletionCheck() (the flag in ignored, no functional effect but > code consistency). This is all I managed to find. What do you think? The patch looks good. The PERFORM_DELETION_INTERNAL removals make sense to me, too.