Date: Thu, 3 Sep 2026 20:51:54 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: jian he <jian.universality@gmail.com>,
	Kirill Reshke <reshkekirill@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CREATE SCHEMA ... CREATE DOMAIN support
Message-ID: <20260904035154.0b.noahmisch@microsoft.com>
References: <685422.1756848241@sss.pgh.pa.us>
 <CACJufxG7okkEs+kjCxR0b=6!!HnzBmMjkUszndT7puTQq6ADXwtQ@mail.gmail.com>
 <3819788.1775241322@sss.pgh.pa.us>
 <841583.1775414546@sss.pgh.pa.us>
 <944307.1775420103@sss.pgh.pa.us>
 <CACJufxEwkAJuCutLQdsxCOJkAvDS=9KgbphMVkXtQP8te=nciA@mail.gmail.com>
 <1199006.1775444695@sss.pgh.pa.us>
 <1838711.1775503188@sss.pgh.pa.us>
 <20260904002924.a7.noahmisch@microsoft.com>
 <1504966.1788483626@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1504966.1788483626@sss.pgh.pa.us>
User-Agent: Mutt/2.3.0 (2026-01-25)
Archived-At: 
 <https://www.postgresql.org/message-id/20260904035154.0b.noahmisch%40microsoft.com>
Precedence: bulk

On Thu, Sep 03, 2026 at 09:00:26PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > CREATE TABLE public.mytable (c int);
> > CREATE SCHEMA myschema
> >   CREATE VIEW myview AS SELECT * FROM mytable
> >   CREATE TABLE mytable (c int);
> > SET search_path = pg_catalog;
> > \d+ myschema.myview
> > RESET search_path;
> 
> > In v18, myview binds to myschema.mytable.  In v19, it binds to public.mytable.
> > I think the above-described syntax rule about <local or schema qualified name>
> > doesn't allow v19's interpretation.
> 
> This is not about that, it is about a9c350d's specific intent "Don't
> try to re-order the subcommands of CREATE SCHEMA".  That is, we
> rejected the idea of allowing forward references between CREATE SCHEMA
> subcommands, therefore myview will not bind to a CREATE TABLE
> subcommand that comes after it.  Frankly, I don't care about arguments
> that this is not what the spec says: I think this behavior is more
> useful, more intelligible, and less bug-prone than the spec's
> semantics.  Moreover we were never going to be able to do what the spec
> says, as discussed in the thread leading up to that commit.

I'm not saying that I want the server to reorder the commands or that I know
of a standard requiring reorder.  I'm fine requiring the user to order things
for us.  The syntax rule I cited[1] appears to require my original example to
have the same name resolution as this variant w/ more schema qualifications:

CREATE TABLE public.mytable (c int);
CREATE SCHEMA myschema
  CREATE VIEW myschema.myview AS SELECT * FROM myschema.mytable
  CREATE TABLE myschema.mytable (c int);
SET search_path = pg_catalog;
\d+ myschema.myview
RESET search_path;

That succeeds in v18 and fails in v19, which is fine.  The problem is that my
original example (with less schema qualification) succeeds in both versions
with different meaning, and the v19 meaning is not standard-compliant.

[1] "If the <local or schema qualified name> is contained in a <schema
definition>, then the <schema name> that is specified or implicit in the
<schema definition> is implicit."

> >> +### D2 — a `SET role` / `SET session_authorization` clause on a routine element is refused under `AUTHORIZATION`, naming a security-definer function that does not exist
> 
> > I would not act on this.
> 
> Hmm, that one seems like a genuine bug to me; why do you think it
> shouldn't be acted on?

It's genuine, but the combination involved is rare enough that I'd shelve it
so long as we're not in a post-scarcity world.  No objection if someone wants
to pursue it.