Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1obYcZ-0003MZ-0z
	for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Sep 2022 02:40:55 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1obYcX-0002fo-Ex
	for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Sep 2022 02:40:53 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1obYcX-0002fe-56
	for pgsql-hackers@lists.postgresql.org; Fri, 23 Sep 2022 02:40:53 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1obYcU-0008GB-QU
	for pgsql-hackers@postgresql.org; Fri, 23 Sep 2022 02:40:52 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28N2ele12032899;
	Thu, 22 Sep 2022 22:40:47 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: libpq error message refactoring
In-reply-to: <20220923022727.mclhsv3cjbmdrrkd@awork3.anarazel.de>
References: <7c0232ef-7b44-68db-599d-b327d0640a77@enterprisedb.com>
 <20220922154225.q4rtgzzsq6pd4f5x@awork3.anarazel.de>
 <d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com>
 <20220923022727.mclhsv3cjbmdrrkd@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 22 Sep 2022 19:27:27 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2032897.1663900847.1@sss.pgh.pa.us>
Date: Thu, 22 Sep 2022 22:40:47 -0400
Message-ID: <2032898.1663900847@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2032898.1663900847%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I suspect the appendPQExpBufferVA is orthogonal - most (all?) of the other
> functions in pqexpbuffer.h are visible, so it feels weird/confusing to not
> make appendPQExpBufferVA() available.

I thought the same to start with, but if I'm right in my nearby reply
that we'll have to make callers loop around appendPQExpBufferVA,
then it seems like a good idea to keep it closely held.

More than zero commentary about that would be a good thing, too.

			regards, tom lane