Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8s8G-0008NH-D6 for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jul 2022 23:39:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o8s8E-0006D4-Vv for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jul 2022 23:39:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8s8E-0006BV-Mk for pgsql-hackers@lists.postgresql.org; Tue, 05 Jul 2022 23:39:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8s8C-0003F9-GY for pgsql-hackers@postgresql.org; Tue, 05 Jul 2022 23:39:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 265NctGp2037584; Tue, 5 Jul 2022 19:38:55 -0400 From: Tom Lane To: Andres Freund cc: Justin Pryzby , Michael Paquier , Robert Haas , Tomas Vondra , pgsql-hackers@postgresql.org Subject: Re: should check interrupts in BuildRelationExtStatistics ? In-reply-to: <20220705232013.56grkfgtfna2cgbq@awork3.anarazel.de> References: <20220509000108.GQ28830@telsasoft.com> <3592964.1652067393@sss.pgh.pa.us> <20220603152837.GO29853@telsasoft.com> <20220605014233.GR29853@telsasoft.com> <20220617222549.GI29853@telsasoft.com> <154878.1656717551@sss.pgh.pa.us> <20220705232013.56grkfgtfna2cgbq@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 05 Jul 2022 16:20:13 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2037582.1657064335.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 05 Jul 2022 19:38:55 -0400 Message-ID: <2037583.1657064335@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > I'm worried about this. Interrupting random qsorts all over seems like i= t > could end up corrupting state. We do things like qsort in building snaps= hots > etc. Are we confident that we handle interrupts reliably in all those pl= aces? Nope ... see my followup just now. regards, tom lane