Subject: Re: Crash by targetted recovery
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <0db8f83f-5b66-75e9-6d99-93f19fc33165@oss.nttdata.com>
 <20200306.102946.81443433484362211.horikyota.ntt@gmail.com>
 <00dac90c-c37d-0a99-6d4d-97acb48a06bf@oss.nttdata.com>
 <20200309.134927.754909343807949809.horikyota.ntt@gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <203fa5df-f98f-35ac-fea9-2aa2ffcdd31a@oss.nttdata.com>
Date: Mon, 9 Mar 2020 15:46:49 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200309.134927.754909343807949809.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/03/09 13:49, Kyotaro Horiguchi wrote:
> At Sat, 7 Mar 2020 01:46:16 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>>> (It seems retroverting to the first patch when I started this...)
>>> The second place covers wider cases so I reverted the first place.
>>
>> Thanks for updating the patch that way.
>> Not sure which patch you're mentioning, though.
> 
> That meant 0003.
> 
>> Regarding 0003 patch, I added a bit more detail comments into
>> the patch so that we can understand the code more easily.
>> Updated version of 0003 patch attached. Barring any objection,
>> at first, I plan to commit this patch.
> 
> Looks good to me. Thanks for writing the detailed comments.

Thanks for the review! Pushed.

I will review other two patches later.

>> There seems to be more other places where XLogSource and
>> XLOG_FROM_XXX are not used yet. For example, the initial values
>> of readSource and XLogReceiptSource, the type of argument
>> "source" in XLogFileReadAnyTLI() and XLogFileRead(), etc.
>> These also should be updated?
> 
> Right. I checked through the file and AFAICS that's all.  The attachec
> v5-0001-Tidy...patch is the fix on top of the v4-0003 on the current
> master.

Thanks for the patch!

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters