Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhS21-0000c0-7E for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jul 2018 04:01:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fhS1z-00027A-Pt for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jul 2018 04:01:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhS1z-00026w-Fz for pgsql-hackers@lists.postgresql.org; Mon, 23 Jul 2018 04:01:07 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhS1x-0008JC-6P for pgsql-hackers@postgresql.org; Mon, 23 Jul 2018 04:01:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w6N4116n020429; Mon, 23 Jul 2018 00:01:01 -0400 From: Tom Lane To: Michael Paquier cc: Noah Misch , Victor Wagner , pgsql-hackers Subject: Re: Non-portable shell code in pg_upgrade tap tests In-reply-to: <20180723033936.GH2854@paquier.xyz> References: <20180720153820.69e9ae6c@fafnir.local.vm> <17833.1532096747@sss.pgh.pa.us> <20180720175508.07776219@fafnir.local.vm> <20015.1532099353@sss.pgh.pa.us> <20180722072904.GA3951499@rfd.leadboat.com> <6519.1532270763@sss.pgh.pa.us> <20180722173857.GA3998719@rfd.leadboat.com> <24717.1532285631@sss.pgh.pa.us> <20180723033936.GH2854@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Mon, 23 Jul 2018 12:39:36 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20427.1532318461.1@sss.pgh.pa.us> Date: Mon, 23 Jul 2018 00:01:01 -0400 Message-ID: <20428.1532318461@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Sun, Jul 22, 2018 at 02:53:51PM -0400, Tom Lane wrote: >> A quick trawl of the buildfarm logs says most of our animals compute >> SHELL = /bin/sh anyway, and so would be unaffected. There's a sizable >> population that find /bin/bash though, and one active critter that finds >> /bin/ksh. > Except for the FreeBSD boxes, right? I thought that using directly > /bin/ and not /usr/local/bin/ was considered an abuse of Linux in their > universe. No, I'm pretty sure that "sh" wins a place in /bin even on FreeBSD ;-) regards, tom lane