From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
cc: "'vignesh C'" <vignesh21@gmail.com>,
        "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
        =?utf-8?B?w5ZuZGVyIEthbGFjxLE=?= <onderkalaci@gmail.com>,
        Fujii Masao <masao.fujii@oss.nttdata.com>,
        "Shinya11.Kato@oss.nttdata.com" <Shinya11.Kato@oss.nttdata.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: [Proposal] Add foreign-server health checks infrastructure
In-reply-to: <TYAPR01MB586613F662443D5A3005CD17F5FF9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
References: <CACawEhW_R=6mKsB24QW3WpCZTQgtxAPH7J0q8yedKkCQY2xT0w@mail.gmail.com> <TYAPR01MB5866F419C4261177578AC1CCF55B9@TYAPR01MB5866.jpnprd01.prod.outlook.com> <CACawEhXAy4gjJ4G3-59Xv_yb8Xbtn1VMYP8SOj-0C9dG2zbAcQ@mail.gmail.com> <TYAPR01MB5866ACB4D3B845B4B2ED121BF55A9@TYAPR01MB5866.jpnprd01.prod.outlook.com> <CACawEhW19nPfbFpvfke9eidFDxAy+ic36wmY0s936T=xzxgHog@mail.gmail.com> <TYAPR01MB5866CFD6BAE6DDF01A27CBF1F5299@TYAPR01MB5866.jpnprd01.prod.outlook.com> <CACawEhUzpqYJ8mQmSjYgX0ePtPpvb2u9Onjf6pCjUGkoZ=-xSg@mail.gmail.com> <TYAPR01MB58668728393648C2F7DC7C85F5399@TYAPR01MB5866.jpnprd01.prod.outlook.com> <CACawEhW56PHQ83Q59x4U5zpi0rVJ6=0Vn-FeYSLZ13Y0yasebQ@mail.gmail.com> <TYAPR01MB5866AAA4EB0632B4001AA2C5F50E9@TYAPR01MB5866.jpnprd01.prod.outlook.com> <20221206182638.w3vrfal4qix4hf2w@awork3.anarazel.de> <TYAPR01MB586635DB5F1C5CE4660175FEF51A9@TYAPR01MB5866.jpnprd01.prod.outlook.com> <TYAPR01MB58660C8F72746C2A8C6381F2F5EA9@TYAPR01MB5866.jpnprd01.prod.outlook.com> <CALDaNm3LaB!
 saJ_RC0L_vKCgxP+cP5tB42eqdFew44KyzbpMXsg@mail.gmail.com> <TYAPR01MB586613F662443D5A3005CD17F5FF9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
Comments: In-reply-to "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
	message dated "Tue, 10 Jan 2023 03:56:59 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <204603.1673324688.1@sss.pgh.pa.us>
Date: Mon, 09 Jan 2023 23:24:48 -0500
Message-ID: <204604.1673324688@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/204604.1673324688%40sss.pgh.pa.us>
Precedence: bulk

"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com> writes:
> Thanks for reporting. PSA rebased version.
> These can be applied work well on my HEAD(bd8d45).

I think that it's a really bad idea to require postgres_fdw.sql
to have two expected-files: that will be a maintenance nightmare.
Please put whatever it is that needs a variant expected-file
into its own, hopefully very small and seldom-changed, test script.
Or rethink whether you really need a test case that has
platform-dependent output.

			regards, tom lane