Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icWza-00039h-7p for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Dec 2019 15:55:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1icWzX-000494-Q7 for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Dec 2019 15:55:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icWzX-00048x-HD for pgsql-hackers@lists.postgresql.org; Wed, 04 Dec 2019 15:55:03 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icWzT-0000gH-Og for pgsql-hackers@lists.postgresql.org; Wed, 04 Dec 2019 15:55:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xB4Fsr1g020463; Wed, 4 Dec 2019 10:54:53 -0500 From: Tom Lane To: Alvaro Herrera cc: Pg Hackers Subject: Re: adding strndup In-reply-to: <20191204144021.GA17976@alvherre.pgsql> References: <20191204144021.GA17976@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Wed, 04 Dec 2019 11:40:21 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20461.1575474893.1@sss.pgh.pa.us> Date: Wed, 04 Dec 2019 10:54:53 -0500 Message-ID: <20462.1575474893@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > I just proposed in > https://postgr.es/m/0191204143715.GA17312@alvherre.pgsql the addition of > strndup() to our src/port. > I think this should be pretty uncontroversial, but wanted to give a > heads-up outside that thread. I attach the patch here for completeness. Grepping, I notice that ecpg has an ecpg_strndup; should that be replaced with this? regards, tom lane