Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oTRbH-0007Sm-MR
	for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Aug 2022 17:34:03 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oTRbF-0005xi-Ue
	for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Aug 2022 17:34:01 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oTRbF-0005xY-Li
	for pgsql-hackers@lists.postgresql.org; Wed, 31 Aug 2022 17:34:01 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oTRbD-0005uy-Ds
	for pgsql-hackers@lists.postgresql.org; Wed, 31 Aug 2022 17:34:01 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 27VHXrnZ020477;
	Wed, 31 Aug 2022 13:33:54 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andres Freund <andres@anarazel.de>, Niyas Sait <niyas.sait@linaro.org>,
        Thomas Munro <thomas.munro@gmail.com>,
        Julien Rouhaud <rjuju123@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
In-reply-to: <Yw77DNnYl1qkaW1S@paquier.xyz>
References: <2679975.1661701879@sss.pgh.pa.us> <YwwSdACDiHqtPkMA@paquier.xyz>
 <Yw1QVptf33FMZw6n@paquier.xyz> <3426682.1661817511@sss.pgh.pa.us>
 <20220830003356.yl7ok3elemonrclo@awork3.anarazel.de>
 <Yw1pZ8X3rG/i8TFn@paquier.xyz> <3479390.1661824810@sss.pgh.pa.us>
 <Yw6e4dA4mmusdEsx@paquier.xyz> <Yw6oBJgXWnJsy3SE@paquier.xyz>
 <3886822.1661905738@sss.pgh.pa.us> <Yw77DNnYl1qkaW1S@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 31 Aug 2022 15:09:16 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20475.1661967233.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 31 Aug 2022 13:33:53 -0400
Message-ID: <20476.1661967233@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20476.1661967233%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> At the end, I'd like to think that it would be wiser to just remove
> entirely the test for node() or reduce the contents of the string to
> be able to strictly control the output order (say a simple
> '<e>pre<![CDATA[&ent1]]>post</e>' would do the trick).  I cannot think
> about a better idea now.  Note that removing the test case where we
> have node() has no impact on the coverage of xml.c.

Yeah, I confirm that: local code-coverage testing shows no change
in the number of lines reached in xml.c when I remove that column:

-SELECT * FROM XMLTABLE('*' PASSING '<e>pre<!--c1--><?pi arg?><![CDATA[&en=
t1]]><n2>&amp;deep</n2>post</e>' COLUMNS x xml PATH 'node()', y xml PATH '=
/');
+SELECT * FROM XMLTABLE('*' PASSING '<e>pre<!--c1--><?pi arg?><![CDATA[&en=
t1]]><n2>&amp;deep</n2>post</e>' COLUMNS y xml PATH '/');

Dropping the query altogether does result in a reduction in the
number of lines hit.

I did not check the other XMLTABLE infrastructure, so what probably
is best to do is keep the two output columns but change 'node()'
to something with a more stable result; any preferences?

			regards, tom lane