From: Chao Li <li.evan.chao@gmail.com>
Message-Id: <2058F900-0706-4B46-A398-54FDABFD29F7@gmail.com>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_3EB901C8-48F2-4007-A479-52C50B787DA9"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: Fix bug of clearing of waitStart in ProcWakeup()
Date: Wed, 25 Feb 2026 06:03:14 +0800
In-Reply-To: 
 <CAHGQGwHJGgZS8iiJVUse1QraMXmYzo+5vw4jd-0MQe5h9pyWXg@mail.gmail.com>
Cc: ji xu <thanksgreed@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
To: Fujii Masao <masao.fujii@gmail.com>
References: <537BD852-EC61-4D25-AB55-BE8BE46D07D7@gmail.com>
 <CANWi6YNc+qC7O086svzf1jO=udJNA8+aa0gqp2BS7tyKB7dLaA@mail.gmail.com>
 <CAHGQGwHJGgZS8iiJVUse1QraMXmYzo+5vw4jd-0MQe5h9pyWXg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/2058F900-0706-4B46-A398-54FDABFD29F7%40gmail.com>
Precedence: bulk


--Apple-Mail=_3EB901C8-48F2-4007-A479-52C50B787DA9
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Feb 24, 2026, at 23:41, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Tue, Feb 24, 2026 at 4:31=E2=80=AFPM ji xu <thanksgreed@gmail.com> =
wrote:
>>=20
>>=20
>> Chao Li <li.evan.chao@gmail.com> =E4=BA=8E2026=E5=B9=B42=E6=9C=8824=E6=97=
=A5=E5=91=A8=E4=BA=8C 14:29=E5=86=99=E9=81=93=EF=BC=9A
>>>=20
>>> Since this function is clearly operating on the parameter proc, the =
only statement that touches MyProc looks suspicious. It should reset =
proc->waitStart, not MyProc->waitStart.
>>>=20
>>> As written, it will incorrectly clear the caller=E2=80=99s waitStart =
instead of the awakened backend=E2=80=99s, potentially leaving a stale =
waitStart value in the target PGPROC.
>=20
> Thanks for the report!
>=20

I just realized that I forgot to attach the patch file. Anyway, that=E2=80=
=99s just a one-line change.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


--Apple-Mail=_3EB901C8-48F2-4007-A479-52C50B787DA9
Content-Disposition: attachment;
	filename=v1-0001-Fix-bug-of-clearing-of-waitStart-in-ProcWakeup.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="v1-0001-Fix-bug-of-clearing-of-waitStart-in-ProcWakeup.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=205a741a41f675a8cff11cdbb20c819e4853ed1499=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20<lic@highgo.com>=0A=
Date:=20Tue,=2024=20Feb=202026=2014:11:24=20+0800=0ASubject:=20[PATCH=20=
v1]=20Fix=20bug=20of=20clearing=20of=20waitStart=20in=20ProcWakeup()=0A=0A=
ProcWakeup()=20incorrectly=20resets=20MyProc->waitStart=20instead=20of=20=
the=0AwaitStart=20field=20of=20the=20process=20being=20awakened.=0A=0A=
Fix=20by=20resetting=20proc->waitStart,=20which=20corresponds=20to=20the=20=
PGPROC=0Abeing=20removed=20from=20the=20wait=20queue.=0A=0AThis=20looks=20=
like=20oversight=20of=2046d6e5f.=0A=0AAuthor:=20Chao=20Li=20=
<lic@highgo.com>=0AReviewed-by:=0ADiscussion:=20https://postgr.es/m/=0A=
---=0A=20src/backend/storage/lmgr/proc.c=20|=202=20+-=0A=201=20file=20=
changed,=201=20insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20=
a/src/backend/storage/lmgr/proc.c=20b/src/backend/storage/lmgr/proc.c=0A=
index=20e2f34075d39..771b006b522=20100644=0A---=20=
a/src/backend/storage/lmgr/proc.c=0A+++=20=
b/src/backend/storage/lmgr/proc.c=0A@@=20-1715,7=20+1715,7=20@@=20=
ProcWakeup(PGPROC=20*proc,=20ProcWaitStatus=20waitStatus)=0A=20=09=
proc->waitLock=20=3D=20NULL;=0A=20=09proc->waitProcLock=20=3D=20NULL;=0A=20=
=09proc->waitStatus=20=3D=20waitStatus;=0A-=09=
pg_atomic_write_u64(&MyProc->waitStart,=200);=0A+=09=
pg_atomic_write_u64(&proc->waitStart,=200);=0A=20=0A=20=09/*=20And=20=
awaken=20it=20*/=0A=20=09SetLatch(&proc->procLatch);=0A--=20=0A2.50.1=20=
(Apple=20Git-155)=0A=0A=

--Apple-Mail=_3EB901C8-48F2-4007-A479-52C50B787DA9--