Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oG426-0005mt-Ug for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Jul 2022 19:46:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oG425-0006No-RX for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Jul 2022 19:46:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oG425-0006NT-HI for pgsql-hackers@lists.postgresql.org; Mon, 25 Jul 2022 19:46:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oG423-0006Nl-Bf for pgsql-hackers@postgresql.org; Mon, 25 Jul 2022 19:46:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26PJkInI2062117; Mon, 25 Jul 2022 15:46:18 -0400 From: Tom Lane To: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= cc: Nathan Bossart , Kyotaro Horiguchi , michael@paquier.xyz, gurjeet@singh.im, pgsql-hackers@postgresql.org Subject: Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS In-reply-to: <87ilnli57b.fsf@wibble.ilmari.org> References: <20220722.151600.1094104349120879204.horikyota.ntt@gmail.com> <729330.1658516182@sss.pgh.pa.us> <20220722223359.GB3998906@nathanxps13> <763512.1658529844@sss.pgh.pa.us> <20220722225615.GC3998906@nathanxps13> <954936.1658597004@sss.pgh.pa.us> <20220725034040.GA4085281@nathanxps13> <1834276.1658720963@sss.pgh.pa.us> <20220725043044.GC4085281@nathanxps13> <2015981.1658759562@sss.pgh.pa.us> <87ilnli57b.fsf@wibble.ilmari.org> Comments: In-reply-to =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= message dated "Mon, 25 Jul 2022 16:26:32 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2062115.1658778378.1@sss.pgh.pa.us> Date: Mon, 25 Jul 2022 15:46:18 -0400 Message-ID: <2062116.1658778378@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes: > Tom Lane writes: >> I wonder if it'd be a good idea to convert >> auto_explain's TAP test to load auto_explain via session_preload_libraries >> instead of shared_preload_libraries, and then pass in the settings for >> each test via PGOPTIONS instead of constantly rewriting postgresql.conf. > That whole config-file rewriting did feel a bit icky when I added more > tests recently, but I completely forgot about PGOPTIONS and -c. > Something like the attached is indeed much nicer. Thanks! I added a test to verify the permissions-checking issue and pushed it. regards, tom lane