From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Geier <geidav.pg@gmail.com>
cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add explicit casts in four places to simplehash.h
In-reply-to: <aa5d88a3-71f4-3455-11cf-82de0372c941@gmail.com>
References: <aa5d88a3-71f4-3455-11cf-82de0372c941@gmail.com>
Comments: In-reply-to David Geier <geidav.pg@gmail.com>
	message dated "Thu, 03 Nov 2022 12:34:41 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2063436.1667487018.1@sss.pgh.pa.us>
Date: Thu, 03 Nov 2022 10:50:18 -0400
Message-ID: <2063437.1667487018@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2063437.1667487018%40sss.pgh.pa.us>
Precedence: bulk

David Geier <geidav.pg@gmail.com> writes:
> What about, while not being strictly necessary for PostgreSQL itself, 
> also adding such casts to simplehash.h so that it can be used in code 
> where -Wc++-compat is enabled?

Seems reasonable, so done (I fixed one additional spot you missed).

The bigger picture here is that we do actually endeavor to keep
(most of) our headers C++ clean, but our tool cpluspluscheck misses
these problems because it doesn't try to use these macros.
I wonder whether there is a way to do better.

			regards, tom lane