From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Robert Haas <robertmhaas@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: initdb's -c option behaves wrong way?
In-reply-to: <2062980.1705523170@sss.pgh.pa.us>
References: <202401171615.uzdmkozzvo6x@alvherre.pgsql>
 <2040188.1705511127@sss.pgh.pa.us>
 <5DFF3111-8ECA-4EF5-B614-9A4C9FAB29BC@yesql.se>
 <CA+TgmoZYa5hNgdadYwNfpReykW7RU5egpzrFaAMwFA9qz0g=eg@mail.gmail.com>
 <2062980.1705523170@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 17 Jan 2024 15:26:10 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2063809.1705523582.1@sss.pgh.pa.us>
Date: Wed, 17 Jan 2024 15:33:02 -0500
Message-ID: <2063810.1705523582@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2063810.1705523582%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> However ... I don't like the patch much.  It seems to have left
> the code in a rather random state.  Why, for example, didn't you
> keep all the code that constructs the "newline" value together?

After thinking about it a bit more, I don't see why you didn't just
s/strncmp/strncasecmp/ and call it good.  The messiness seems to be
a result of your choice to replace the GUC's case as shown in the
file with the case used on the command line, which is not better
IMO.  We don't change our mind about the canonical spelling of a
GUC because somebody varied the case in a SET command.

			regards, tom lane