Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daCvI-00074N-6L for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Jul 2017 03:23:44 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1daCvG-0006e3-8b for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Jul 2017 03:23:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1daCtj-0003xL-N3 for pgsql-hackers@postgresql.org; Wed, 26 Jul 2017 03:22:07 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1daCtg-0006bs-Ua for pgsql-hackers@postgresql.org; Wed, 26 Jul 2017 03:22:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v6Q3Lsco020730; Tue, 25 Jul 2017 23:21:54 -0400 From: Tom Lane To: Robert Haas cc: Ashutosh Sharma , Andrew Dunstan , Dave Page , Sandeep Thakkar , "pgsql-hackers@postgresql.org" Subject: Re: pl/perl extension fails on Windows In-reply-to: References: <4569.1499873707@sss.pgh.pa.us> <6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com> <184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com> <16093.1499956602@sss.pgh.pa.us> <7480.1499965218@sss.pgh.pa.us> <30585.1500480763@sss.pgh.pa.us> <32468.1500498091@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Tue, 25 Jul 2017 23:08:03 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20728.1501039314.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 25 Jul 2017 23:21:54 -0400 Message-ID: <20729.1501039314@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > Based on discussion downthread, it seems like what we actually need to > do is update perl.m4 to extract CCFLAGS. Turns out somebody proposed > a patch for that back in 2002: > https://www.postgresql.org/message-id/Pine.LNX.4.44.0211051045070.16317-2= 00000%40wotan.suse.de > It seems to need a rebase. :-) Ah-hah, I *thought* we had considered the question once upon a time. There were some pretty substantial compatibility concerns raised in that thread, which is doubtless why it's still like that. My beef about inter-compiler compatibility (if building PG with a different compiler from that used for Perl) could probably be addressed by absorbing only -D switches from the Perl flags. But Peter seemed to feel that even that could break things, and I worry that he's right for cases like -D_FILE_OFFSET_BITS which affect libc APIs. Usually we'd have made the same decisions as Perl for that sort of thing, but if we didn't, it's a mess. I wonder whether we could adopt some rule like "absorb -D switches for macros whose names do not begin with an underscore". That's surely a hack and three-quarters, but it seems safer than just absorbing everything willy-nilly. regards, tom lane --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers