Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id DFE971337B82 for ; Thu, 13 Jan 2011 20:25:21 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 98866-02 for ; Fri, 14 Jan 2011 00:25:16 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 67EE11337B68 for ; Thu, 13 Jan 2011 20:25:14 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p0E0P9s5020768; Thu, 13 Jan 2011 19:25:09 -0500 (EST) To: Robert Haas cc: Magnus Hagander , Greg Smith , pgsql-hackers@postgresql.org Subject: Re: auto-sizing wal_buffers In-reply-to: References: Comments: In-reply-to Robert Haas message dated "Thu, 13 Jan 2011 17:31:04 -0500" Date: Thu, 13 Jan 2011 19:25:09 -0500 Message-ID: <20767.1294964709@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201101/1031 X-Sequence-Number: 178868 Robert Haas writes: > On Thu, Jan 13, 2011 at 5:29 PM, Magnus Hagander wrote: >> +1, I like the idea. Would it still be there to override if necessary? > Depends what people want to do. We could make the default "0kB", and > define that to mean "auto-tune", or we could remove the parameter > altogether. I think I was envisioning the latter, but if people are > hesitant to do that we could do the former instead. I think we need to keep the override capability until the autotune algorithm has proven itself in the field for a couple of years. I agree with Josh that a negative value should be used to select the autotune method. regards, tom lane