From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Robert Haas <robertmhaas@gmail.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Julien Rouhaud <rjuju123@gmail.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: suggest to rename enable_incrementalsort
In-reply-to: <20200622152219.GC28999@momjian.us>
References: <df652910-e985-9547-152c-9d4357dc3979@2ndquadrant.com>
 <CAOBaU_bsOKEXgF_ik3bjAfV7HQAM+2MTbAwtKujqiu1YueeUiQ@mail.gmail.com>
 <20200621112159.qtgedtrqw2c47pm4@development>
 <CA+TgmoazhPwebpOwNbHt1vJoos1eLYhJVQPka+pptSLgS685aA@mail.gmail.com>
 <2037457.1592836877@sss.pgh.pa.us> <20200622152219.GC28999@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Mon, 22 Jun 2020 11:22:19 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2079433.1592842594.1@sss.pgh.pa.us>
Date: Mon, 22 Jun 2020 12:16:34 -0400
Message-ID: <2079434.1592842594@sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> On Mon, Jun 22, 2020 at 10:41:17AM -0400, Tom Lane wrote:
>> Maybe I'm just used to the names, but I find that things like
>> "enable_seqscan" and "enable_nestloop" are pretty readable.
>> Once they get longer, though, not so much.  So I agree with
>> renaming enable_incrementalsort.

> I think the big problem is that, without the extra underscore, it reads
> as increment-alsort.  ;-)

Yeah, the longer the name gets, the harder it is to see where the
word boundaries are.

			regards, tom lane