From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Michael Paquier <michael.paquier@gmail.com>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Haribabu Kommi <kommi.haribabu@gmail.com>,
        Dmitry Vasilyev <d.vasilyev@postgrespro.ru>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re:
 =?UTF-8?Q?Re=3A_=5BHACKERS=5D_Re=3A_=5BHACKERS=5D_Re=3A_=5BHACKERS=5D_Re=3A_=5BHACKE?=
 =?UTF-8?Q?RS=5D_Windows_service_is_not_starting_so_there=E2=80=99s_message_in_?=
 =?UTF-8?Q?log=3A_FATAL=3A_=22could_not_create_shared_memory_segment_=E2=80=9CGloba?=
 =?UTF-8?Q?l=2FPostgreSQL=2E851401618=E2=80=9D=3A_Permission_denied=E2=80=9D?=
In-reply-to: 
 <CA+TgmoaEG+BXm28YsPC8HD4yQWhkQd8fupXyrzNGqOhqvCJJbw@mail.gmail.com>
References: <1444920387.3661.7.camel@postgrespro.ru>
 <1444921511.3661.13.camel@postgrespro.ru>
 <CAA4eK1+pjtDouF-Lc9y0UgFDmWHnaf4KwiM1Y3Anq0wZ1gwsAA@mail.gmail.com>
 <CA+TgmoZiYV=fFnWQZbfjZ250=YYxAWn_XETGVdUpwFnKxd7B9A@mail.gmail.com>
 <CAA4eK1K-c0P7_RVRUFrkgQyy-X4JC1rDyHpZiUQeJJJPpAy_jw@mail.gmail.com>
 <31461.1445090619@sss.pgh.pa.us>
 <CAJrrPGfkMyYmr+7fki+nKsWGZ0LOXMgPJSixSFo=uL6MFF=OGQ@mail.gmail.com>
 <CAA4eK1JTS3bOUX8KHGJrhGs5i54FdbU0Ez4PMqDqj5r_KvwKOQ@mail.gmail.com>
 <CAJrrPGcC27MYAmeHq=o8zo52c+-X7NbrzF26d1CZBS-JQkHaYQ@mail.gmail.com>
 <CAA4eK1J7mSohkNb2q0yUn8aFdfaR66jH3HnWi6pT4XaXRrdxjQ@mail.gmail.com>
 <CAJrrPGcT8URvcyeWzZcHgB6PVyus-r785thn6vUGZ9SyA3Kq8A@mail.gmail.com>
 <CAA4eK1LSqMRWnjnakWejfKg8_Bt7DZvBTHUsYbP1MerXxX7YYw@mail.gmail.com>
 <CAJrrPGfnFB+wmc3FMo6f9fC+p5+mevw5nQdkMSqfTB-1Ey=wmA@mail.gmail.com>
 <CAA4eK1K+c3Scr4WPcnt6=UQX6ZttJkHOe5+UQ3mMtjAnq2xGdQ@mail.gmail.com>
 <CAJrrPGcEyYbffNh6VEpXaykVsGthvZ7Qhn4d6TmxsHda5MPDtQ@mail.gmail.com>
 <CAA4eK1Jgm3MxO1=RAGJWE1cARQxFwUe!
 48pFgFZ_GEGwMiCWM2A@mail.gmail.c
 <CA+TgmoaEG+BXm28YsPC8HD4yQWhkQd8fupXyrzNGqOhqvCJJbw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Tue, 20 Sep 2016 12:14:35 -0400"
Date: Tue, 20 Sep 2016 13:03:07 -0400
Message-ID: <20811.1474390987@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, May 26, 2016 at 7:44 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> Yeah, it is definitely better to register it. And I have switched the
>> patch as ready for committer just now.

> Committed and back-patched to 9.4, where DSM was introduced.

ISTM both the previous coding and this version can fail for no good
reason, that is what if GetLastError() happens to return one of these
error codes as a result of some unrelated failure from before this
subroutine is entered?  That is, wouldn't it be a good idea to
do SetLastError(0) before calling CreateFileMapping?  Or is the latter
guaranteed to do that on success?  I don't see that stated in its
man page.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers