From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Peter Smith <smithpb2250@gmail.com>,
 Jim Jones <jim.jones@uni-muenster.de>,
        pgsql-hackers@lists.postgresql.org,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: [PATCH] Add pretty-printed XML output option
In-reply-to: <20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql>
References: <20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Wed, 15 Feb 2023 11:11:59 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2083678.1676473663.1@sss.pgh.pa.us>
Date: Wed, 15 Feb 2023 10:07:43 -0500
Message-ID: <2083679.1676473663@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2083679.1676473663%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Note that there's another file, xml_2.out, which does not contain the
> additional part of the DETAIL message.  I suspect in Peter's case it's
> xml_2.out that was originally being used as a comparison basis (not
> xml.out), but that one is not getting patched, and ultimately the diff
> is reported for him against xml.out because none of them matches.
> See commit 085423e3e326 for a bit of background.

Yeah.  That's kind of sad, because it means there are still broken
libxml2s out there in 2023.  Nonetheless, since there are, it is not
optional to fix all three expected-files.

			regards, tom lane