From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>
Subject: Re: CLOBBER_CACHE_ALWAYS regression instability
In-reply-to: <20200405185749.5pi3k6w2jd2x3kgu@alap3.anarazel.de>
References: <30675.1586111599@sss.pgh.pa.us>
 <20200405185749.5pi3k6w2jd2x3kgu@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 05 Apr 2020 11:57:49 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2083.1586115509.1@sss.pgh.pa.us>
Date: Sun, 05 Apr 2020 15:38:29 -0400
Message-ID: <2084.1586115509@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2020-04-05 14:33:19 -0400, Tom Lane wrote:
>> 1. Change the test to do "\set VERBOSITY sqlstate" so that all that
>> is printed is
>> ERROR:  54001
>> ERRCODE_STATEMENT_TOO_COMPLEX is used in few enough places that
>> this wouldn't be too much of a loss of specificity.  (Or we could
>> give stack overflow its very own ERRCODE.)

> We could print the error using :LAST_ERROR_MESSAGE after removing a
> potential trailing "at character ..." if we're worried about the loss of
> specificity.

Oh, actually it seems that :LAST_ERROR_MESSAGE is already just the
primary message, without any "at character N" addon, so this would be
a very easy way to ameliorate that complaint.  ("at character N" is
added by libpq's pqBuildErrorMessage3 in TERSE mode, but psql does
not use that when filling LAST_ERROR_MESSAGE.)

			regards, tom lane