Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7xJY-0004QH-0j for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 15:17:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7xJX-000zJ9-0B for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 15:17:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7xJW-000zJ0-2M for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 15:17:03 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7xJV-000000001rD-0CZi for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 15:17:02 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-43cfb723698so3028499f8f.3 for ; Wed, 01 Apr 2026 08:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1775056619; x=1775661419; darn=lists.postgresql.org; h=message-id:date:content-transfer-encoding:mime-version:comments :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AHL9njGR7/sKONorsk2L/0BWLI4NbJPrpNBujMaumkI=; b=r1MW5pdh20GeGAANvGP0mZmBoSSid6SokDEOly+5T/7Ho4c+gVr0/r4JbL94MjEQVt zg3/Arpx7WYNFcgsWgX9xdiogXOqZtGRXi41W4SQhN5xrMK4PtSb4h29IsKSmNmXRQwj o2b17PH6KBATmvLJ+oiODcgOSoxMV2iT5Cqk0q1S2gPcIL+32dU1i4yrUcraddRqCKVa pKn91aPl61wAnPpCeabLxk+Qu0W2TlETVvpF35Ox+WOKUhITpTrTjG/k943YME4+bXIU 1icreCvNS73IjU4lM8m30/BE3lVMYDI20TjgI/qZQkoIUJHKjFwAAaA3rGlMYyCpeOr0 KZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775056619; x=1775661419; h=message-id:date:content-transfer-encoding:mime-version:comments :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AHL9njGR7/sKONorsk2L/0BWLI4NbJPrpNBujMaumkI=; b=ZcW6pz9NTYzefsv+8GNEFpj3I1CgPKh7Iwe0fCDqwQn9yDdNl1rLPU14SQpDyCyHUx 7qEGebsrsi1KLqF9XH6l7/zzoi1mlgl/5UFgAGkM8nAZ+QjM/IGH530RsqCbmvGaPXiU RWE7jZzBpA6evPXdjEn5jU99GG7q6pkIY71fr1y2paa2Kr+J93qehFsXAooPnnekTr3e IYBbotL8qdQM2+suiyvFKbT/A4zuMC7zsvxLBRR31jMcknxfVknla15pd/HQauq5Ah40 dhUW4kM8MX3RSwHFT3GQSTpCb55fBCyA0qIObiJfAbHLMehljd0q/0ZybSf53RjWA6dM gGgg== X-Forwarded-Encrypted: i=1; AJvYcCVzffV+2PIcctVvlq5k5PcA6d5nUC37T/0Sm/rddWBznyRsy1ySRNjUKXQsEa9dbFw8hhF4/swtsFu5myMY@lists.postgresql.org X-Gm-Message-State: AOJu0YxqLduX3o1X5eLkjhTx9OHKUyWz1JHmbwzic4R5lShelyjuf2Bm pJf+7F5e8tHUtYISjJBSb20wT6XEI4VRBGbz9Kxn6zEmYMtjQvt4FiAN0JF3JpjnAXU= X-Gm-Gg: ATEYQzwOd8b9vK4ZqwTzDCfcFD7gnFM6bESVIyry64fChOEChckAKVg2aSQSX7K0yoh SyJocszHQkKxnYjr9iEUoBt5Gnpwm+fLzzcpEQHUJJ9+e3NOSgLNVcv6d746LCKFS9PgpX6MS5S uDb9zA04BWr/+nBZhHdBNc5sn97Y6C55ACIujQTZSRk1RET9EO/7eAcJIXkl0yit5BZMSW4ncZj HJyk+JxL3Vz3JRR7lXWmtfv9ah6lrugnB3b+pVmlyvqzFjnKPNHlBXtXj2kZTkGkkZIRaxcpWZi h8WakKrfFNqEWcGA7H9IZqe1wcsW/ES/523XnWAFn5Wka3VQQgG4xvO8Dd1TgdHIg/ZvtzHf3EW 2GR/pWTpvCz4Hb7IHbMBVHcETSmUqLFL0fTtm4c1McpZr9RkymdVV5XyVI/f1z1md3pspX7DLS3 0bOYpsjq3dsY1AKsEWnCfNtGJogNlCZ6pewL92 X-Received: by 2002:a05:6000:4013:b0:437:711c:8754 with SMTP id ffacd0b85a97d-43d15048670mr7834060f8f.7.1775056619455; Wed, 01 Apr 2026 08:16:59 -0700 (PDT) Received: from localhost (109-81-168-142.rct.o2.cz. [109.81.168.142]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c5253sm531237f8f.9.2026.04.01.08.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 08:16:59 -0700 (PDT) From: Antonin Houska To: alvherre@kurilemu.de cc: Chao Li , Andres Freund , Pg Hackers , Zsolt Parragi , Nathan Bossart Subject: Re: table AM option passing In-reply-to: <202604011417.bwthhrwmivd4@alvherre.pgsql> References: <202604011417.bwthhrwmivd4@alvherre.pgsql> Comments: In-reply-to =?us-ascii?Q?=3D=3Futf-8=3FQ=3F=3DC3=3D81lvaro=3F=3D?= Herrera message dated "Wed, 01 Apr 2026 16:27:18 +0200." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 01 Apr 2026 17:16:58 +0200 Message-ID: <209310.1775056618@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk =C3=81lvaro Herrera wrote: > Hmm, this is actually a problem in 1bd6f22f43ac. I added a preliminary > patch that should fix this. I've reviewed this patch set too. The only question that occurs to me is whether INSERT_SKIP_FSM and INSERT_FROZEN shouldn't actually be prefixed wi= th HEAP_, as these are rather low-level and thus might be considered AM-specific. (I like the idea to use the high bits to avoid collisions.) --=20 Antonin Houska Web: https://www.cybertec-postgresql.com