From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: "postmaster became multithreaded" is reachable
In-reply-to: <20250123183837.79.nmisch@google.com>
References: <206317.1737656533@sss.pgh.pa.us>
 <20250123183837.79.nmisch@google.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Thu, 23 Jan 2025 10:38:37 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <209557.1737658292.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 23 Jan 2025 13:51:32 -0500
Message-ID: <209558.1737658292@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/209558.1737658292%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Thu, Jan 23, 2025 at 01:22:13PM -0500, Tom Lane wrote:
>> An alternative idea (that maybe should also be done in PostmasterMain)
>> is to report the HINT only #ifdef __darwin__ and on other platforms
>> use the "Please report a bug" text.

> I gather pthread_is_threaded_np() is still macOS-only, in which case the
> !darwin branch would be future-proofing only.

Ah, I had not realized that.  Perhaps the comments about this code
should mention that?

> Another alternative would be to track whether we reached the startup-tim=
e
> check, emitting a message at exit only if we did reach the startup-time =
check.
> If a postmaster passes the startup-time check and fails the exit-time ch=
eck,
> changing the environment won't help.  Even so, I'm content with your fir=
st
> proposal.

Yeah, seems like overcomplication.  Let's go with the simple way.

			regards, tom lane