From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <20CFEB28-9CF8-4AD8-BB7F-0E8A9EDA8BA7@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_72C09ADB-58A9-4DD7-9952-63CD468CA792"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: New developer papercut - Makefile references INSTALL
Date: Tue, 18 Jan 2022 16:51:09 +0100
In-Reply-To: <4EE5D9D9-AE71-4830-8DEE-01E91565244B@yesql.se>
Cc: Tim McNamara <tim@mcnamara.nz>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
To: Magnus Hagander <magnus@hagander.net>
References: <730dae39-abaa-4140-893b-95d732fed003@www.fastmail.com>
 <F2F48D23-6109-474B-9D9A-95294804B488@yesql.se>
 <CABUevEw4qN0jQyWyo7w4YkJRV=F15VSE_tLTL-UcPkYAAFEZVg@mail.gmail.com>
 <4EE5D9D9-AE71-4830-8DEE-01E91565244B@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/20CFEB28-9CF8-4AD8-BB7F-0E8A9EDA8BA7%40yesql.se>
Precedence: bulk


--Apple-Mail=_72C09ADB-58A9-4DD7-9952-63CD468CA792
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

> On 17 Jan 2022, at 13:26, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 17 Jan 2022, at 11:25, Magnus Hagander <magnus@hagander.net> wrote:
> 
>> That said, I'm not sure we're actually gaining anything by *not*
>> referring to the website as well. TBH, I bet the majority of users
>> will actually prefer to read them there. So I'd suggest always
>> including the reference to the website as well, per the suggestion
>> from Tim.
> 
> Fair point, I'll go ahead and do that in a bit unless anyone objects.

I plan on applying the attached which address the feedback given.

--
Daniel Gustafsson		https://vmware.com/


--Apple-Mail=_72C09ADB-58A9-4DD7-9952-63CD468CA792
Content-Disposition: attachment;
	filename=install_v2.diff
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="install_v2.diff"
Content-Transfer-Encoding: 7bit

diff --git a/Makefile b/Makefile
index 99dcfff654..97b9f2bcbc 100644
--- a/Makefile
+++ b/Makefile
@@ -17,8 +17,14 @@ all:
 
 all check install installdirs installcheck installcheck-parallel uninstall clean distclean maintainer-clean dist distcheck world check-world install-world installcheck-world:
 	@if [ ! -f GNUmakefile ] ; then \
+	   if [ -f INSTALL ] ; then \
+	       INSTRUCTIONS="'INSTALL'"; \
+	   else \
+		   INSTRUCTIONS="'README.git'"; \
+	   fi; \
 	   echo "You need to run the 'configure' program first. See the file"; \
-	   echo "'INSTALL' for installation instructions." ; \
+	   echo "$$INSTRUCTIONS for installation instructions, or visit: " ; \
+	   echo "<https://www.postgresql.org/docs/devel/installation.html>" ; \
 	   false ; \
 	 fi
 	@IFS=':' ; \

--Apple-Mail=_72C09ADB-58A9-4DD7-9952-63CD468CA792--