pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Anybody want to check for Windows timezone updates?
5+ messages / 2 participants
[nested] [flat]

Commits from this thread:
  2020-04-24 1e07e3fc00 f65f3a5d8e 6c5f916168 3cdb45c549 b31f9fd633 40d4bc5acd  Update Windows timezone name list to include currently-known zones.
  2020-04-24 351252904a a2342c6582 99c9ed2242 bd8c5cee96 3f3ab184c6 4985b3b849  Improve placement of "display name" comment in win32_tzmap[] entries.
* Anybody want to check for Windows timezone updates?
@ 2020-04-24 15:01  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2020-04-24 15:01 UTC (permalink / raw)
  To: pgsql-hackers@lists.postgresql.org

src/timezone/README mentions

  When there has been a new release of Windows (probably including Service
  Packs), the list of matching timezones need to be updated. Run the
  script in src/tools/win32tzlist.pl on a Windows machine running this new
  release and apply any new timezones that it detects. Never remove any
  mappings in case they are removed in Windows, since we still need to
  match properly on the old version.

It's been some years since this was last done (a79a68562, looks like).
Anybody want to check if updates are needed?

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Anybody want to check for Windows timezone updates?
@ 2020-04-24 17:42  Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Juan José Santamaría Flecha @ 2020-04-24 17:42 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Fri, Apr 24, 2020 at 5:01 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
> It's been some years since this was last done (a79a68562, looks like).
> Anybody want to check if updates are needed?
>

Please find attached the output from Windows Server 2019.

Regards,

Juan José Santamaría Flecha

Attachments:

  win32tzlist.log (application/octet-stream, 5.0K) download

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Anybody want to check for Windows timezone updates?
@ 2020-04-24 21:55  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2020-04-24 21:55 UTC (permalink / raw)
  To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo.santamaria@gmail.com> writes:
> Please find attached the output from Windows Server 2019.

Thanks!  That was a bit tedious --- I suppose it's not quite worth
automating further, but I did make some effort to remove the cross-version
formatting hazards in that table.

Could you verify that there are no complaints now with HEAD?
I might've fat-fingered something.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Anybody want to check for Windows timezone updates?
@ 2020-04-25 09:05  Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Juan José Santamaría Flecha @ 2020-04-25 09:05 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Fri, Apr 24, 2020 at 11:55 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
> Thanks!  That was a bit tedious --- I suppose it's not quite worth
> automating further, but I did make some effort to remove the cross-version
> formatting hazards in that table.
>

That might explain why it gets updated not so often. Forcing errors with a
Spanish installation, so please forget about the description, the new
format is more consistent with findtimezone.c:

        {
                /* (UTC+04:30) Kabul */
                "Hora estßndar de Afganistßn", "Hora de verano de
Afganistßn",
                "FIXME"
        },

Could you verify that there are no complaints now with HEAD?
> I might've fat-fingered something.
>

Nothing gets reported with current HEAD.

Regards,

Juan José Santamaría Flecha

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Anybody want to check for Windows timezone updates?
@ 2020-04-25 14:36  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
  0 siblings, 0 replies; 5+ messages in thread

From: Tom Lane @ 2020-04-25 14:36 UTC (permalink / raw)
  To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo.santamaria@gmail.com> writes:
>> Could you verify that there are no complaints now with HEAD?
>> I might've fat-fingered something.

> Nothing gets reported with current HEAD.

OK, thanks for checking!

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2020-04-25 14:36 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 15:01 Anybody want to check for Windows timezone updates? Tom Lane <tgl@sss.pgh.pa.us>
2020-04-24 17:42 ` Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
2020-04-24 21:55   ` Tom Lane <tgl@sss.pgh.pa.us>
2020-04-25 09:05     ` Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
2020-04-25 14:36       ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox