From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
In-reply-to: <79ed5348-be7a-b647-dd40-742207186a22@2ndquadrant.com>
References: <79ed5348-be7a-b647-dd40-742207186a22@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Wed, 20 May 2020 11:52:25 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21041.1589983015.1@sss.pgh.pa.us>
Date: Wed, 20 May 2020 09:56:55 -0400
Message-ID: <21042.1589983015@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> If I run pgindent on a built tree on macos, I get this error
> Failure in ./src/backend/utils/probes.h: Error@375: Stuff missing from 
> end of file
> The file in question is built by the dtrace command.  I have attached it 
> here.
> Is this something to fix in pgindent?  Or should this file be excluded, 
> since it's generated?

Hm, there's nothing obviously wrong with the file.  But since it's
generated by code not under our control, we should exclude it.
And given that, it's probably not worth figuring out why it breaks
pgindent.

On a closely related point: I was confused for awhile on Monday
afternoon, wondering why the built tarballs didn't match my local
tree.  I eventually realized that when I'd run pgindent on Saturday,
it had reformatted some generated files such as
src/bin/psql/sql_help.h, causing those not to match the freshly-made
ones in the tarball.  I wonder if we should make an effort to ensure
that our generated .h and .c files always satisfy pgindent.  If not,
we probably should exclude them too.

			regards, tom lane