Content-Type: multipart/mixed; boundary="------------80ezoVsMW7ZQUOXteSYzTZVx"
Message-ID: <21088129-7cd3-424a-bcce-6a3427ba3276@postgrespro.ru>
Date: Tue, 20 Feb 2024 10:18:23 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
Content-Language: en-US
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: jian he <jian.universality@gmail.com>,
 Alena Rybakina <a.rybakina@postgrespro.ru>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, "Finnerty, Jim" <jfinnert@amazon.com>,
 Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Peter Eisentraut <peter@eisentraut.org>
References: <567ED6CA.2040504@sigaev.ru>
 <CACJufxGXhJ823cdAdp2Ho7qC-HZ3_-dtdj-myaAi_u9RQLn45g@mail.gmail.com>
 <CACJufxG=wB6qLbOAWaYEQHccN+qi=6-pw7zKVWZ53ZiDZNRTRA@mail.gmail.com>
 <CACJufxFrZS07oBHMk1_c8P3A84VZ3ysXiZV8NeU6gAnvu+HsVA@mail.gmail.com>
 <a155849d-7e74-4700-8c55-8a945d42935e@postgrespro.ru>
 <CACJufxFS-xcjaWq2Du2OyJUjRAyqCk12Q_zGOPxv61sgrdpw9w@mail.gmail.com>
 <7e11e27b-7ab9-4d59-af0a-a921861a9206@postgrespro.ru>
 <13ad923a-33df-4b44-9e00-c9323cd4c37d@postgrespro.ru>
 <CACJufxFSfSGZpmVt_98SRojdugW2s9H-qYm2sYr0A3o-xPea0g@mail.gmail.com>
 <e3338e82-a28d-4631-9eec-b9c0984b32d5@postgrespro.ru>
 <1cf6b382-6e27-4268-9f2a-54ada66eb2eb@postgrespro.ru>
 <CACJufxH-zju3VfosSRBu8d3xs99sGENn6+P3AETLuTiAPFY+0g@mail.gmail.com>
 <5f119769-ab11-4807-abcc-71d5dd914ea0@postgrespro.ru>
 <CACJufxFMFoosvbuFYDiFtpam4sKCSGJeh5jYiZSY8PHjCpEHYA@mail.gmail.com>
 <cf0d1615-b594-404d-9a23-3d8ffd9070ec@postgrespro.ru>
 <CAEudQAq4XTcwhw2OmfW1AJNqvMfbReEWjuzqv6YTz6ZjbpmL0g@mail.gmail.com>
From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: <CAEudQAq4XTcwhw2OmfW1AJNqvMfbReEWjuzqv6YTz6ZjbpmL0g@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/21088129-7cd3-424a-bcce-6a3427ba3276%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------80ezoVsMW7ZQUOXteSYzTZVx
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 19/2/2024 19:53, Ranier Vilela wrote:
> v17-0002
> 1) move the vars *arrayconst and *dest, to after if, to avoid makeNode 
> (palloc).
> + Const   *arrayconst;
> + ScalarArrayOpExpr  *dest;
> +
> + pd = (PredicatesData *) lfirst(lc);
> + if (pd->elems == NIL)
> + /* The index doesn't participate in this operation */
> + continue;
> 
> + arrayconst = lsecond_node(Const, saop->args);
> + dest = makeNode(ScalarArrayOpExpr);
Thanks for the review!
I'm not sure I understand you clearly. Does the patch in attachment fix 
the issue you raised?

-- 
regards,
Andrei Lepikhov
Postgres Professional

--------------80ezoVsMW7ZQUOXteSYzTZVx
Content-Type: text/plain; charset=UTF-8; name="fix.diff"
Content-Disposition: attachment; filename="fix.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2luZHhwYXRoLmMgYi9z
cmMvYmFja2VuZC9vcHRpbWl6ZXIvcGF0aC9pbmR4cGF0aC5jCmluZGV4IDU2YjA0NTQxZGIu
LjE1NDU4NzZlMmYgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2lu
ZHhwYXRoLmMKKysrIGIvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BhdGgvaW5keHBhdGguYwpA
QCAtMTI4NCw3ICsxMjg0LDcgQEAgYnVpbGRfcGF0aHNfZm9yX1NBT1AoUGxhbm5lckluZm8g
KnJvb3QsIFJlbE9wdEluZm8gKnJlbCwgUmVzdHJpY3RJbmZvICpyaW5mbywKIAkJQXJyYXlU
eXBlCQkgICAqYXJyYXl2YWwgPSBOVUxMOwogCQlBcnJheUV4cHIJCSAgICphcnIgPSBOVUxM
OwogCQlDb25zdAkJCSAgICphcnJheWNvbnN0ID0gbHNlY29uZF9ub2RlKENvbnN0LCBzYW9w
LT5hcmdzKTsKLQkJU2NhbGFyQXJyYXlPcEV4cHIgICpkZXN0ID0gbWFrZU5vZGUoU2NhbGFy
QXJyYXlPcEV4cHIpOworCQlTY2FsYXJBcnJheU9wRXhwcglkZXN0OwogCiAJCXBkID0gKFBy
ZWRpY2F0ZXNEYXRhICopIGxmaXJzdChsYyk7CiAJCWlmIChwZC0+ZWxlbXMgPT0gTklMKQpA
QCAtMTMwMiwxMCArMTMwMiwxMCBAQCBidWlsZF9wYXRoc19mb3JfU0FPUChQbGFubmVySW5m
byAqcm9vdCwgUmVsT3B0SW5mbyAqcmVsLCBSZXN0cmljdEluZm8gKnJpbmZvLAogCQlhcnIt
Pm11bHRpZGltcyA9IGZhbHNlOwogCiAJCS8qIENvbXBvc2UgbmV3IFNBT1AsIHBhcnRpYWxs
eSBjb3ZlcmluZyB0aGUgc291cmNlIG9uZSAqLwotCQltZW1jcHkoZGVzdCwgc2FvcCwgc2l6
ZW9mKFNjYWxhckFycmF5T3BFeHByKSk7Ci0JCWRlc3QtPmFyZ3MgPSBsaXN0X21ha2UyKGxp
bml0aWFsKHNhb3AtPmFyZ3MpLCBhcnIpOworCQltZW1jcHkoJmRlc3QsIHNhb3AsIHNpemVv
ZihTY2FsYXJBcnJheU9wRXhwcikpOworCQlkZXN0LmFyZ3MgPSBsaXN0X21ha2UyKGxpbml0
aWFsKHNhb3AtPmFyZ3MpLCBhcnIpOwogCi0JCWNsYXVzZSA9IChFeHByICopIGVzdGltYXRl
X2V4cHJlc3Npb25fdmFsdWUocm9vdCwgKE5vZGUgKikgZGVzdCk7CisJCWNsYXVzZSA9IChF
eHByICopIGVzdGltYXRlX2V4cHJlc3Npb25fdmFsdWUocm9vdCwgKE5vZGUgKikgJmRlc3Qp
OwogCiAJCS8qCiAJCSAqIENyZWF0ZSBuZXcgUmVzdHJpY3RJbmZvLiBJdCBtYXliZSBtb3Jl
IGhlYXZ5IHRoYW4ganVzdCBjb3B5IG5vZGUsCg==

--------------80ezoVsMW7ZQUOXteSYzTZVx--