From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Pavan Deolasee <pavan.deolasee@gmail.com>, amul sul <sulamul@gmail.com>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Stephen Frost <sfrost@snowman.net>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Restrict concurrent update/delete with UPDATE of
 partition key
In-reply-to: 
 <CA+TgmoZzaH3WMhyLg_STX6=J+5iqQ0GvRWBnQihgDarF_mWSYg@mail.gmail.com>
References: 
 <CAAJ_b95PkwojoYfz0bzXU8OokcTVGzN6vYGCNVUukeUDrnF3dw@mail.gmail.com>
 <CA+TgmoYY98AEjh7RDtuzaLC--_0smCozXRu6bFmZTaX5Ne=B5Q@mail.gmail.com>
 <CAAJ_b94mc5jhgyPpG2RqJkKTxcgCrkg-6P-Ms2gPTxcctXB53g@mail.gmail.com>
 <CAA4eK1LQS6TmsGaEwR9HgF-9TZTHxrdAELuX6wOZBDbbjOfDjQ@mail.gmail.com>
 <CAAJ_b95izaDNQGTO=46AQnuQ10qvvAoSqNBicmZ9eosq2-gmjA@mail.gmail.com>
 <CAA4eK1LB0bAv4rADwoQSvb7u8evAvVNnume4dqjk_6C5YNajTw@mail.gmail.com>
 <CAAJ_b95Nc72DGGJk-_RBeNLq5P0OFQz+pMR4Z_xBDNbwy8kj3w@mail.gmail.com>
 <20180111143641.GJ2416@tamriel.snowman.net>
 <CAAJ_b96UMma8VUMtvqDzEWUFObfbNXAc-9c4GvAQ2kSwCKURww@mail.gmail.com>
 <CAA4eK1LHVnNWYF53F1gUGx6CTxuvznozvU-Lr-dfE=Qeu1gEcg@mail.gmail.com>
 <CAAJ_b95R4i-+4VevSYEg1HdT+Zq6v5BuZ1zD14-yzpxe+kioqg@mail.gmail.com>
 <CAA4eK1LrOf+ZGkjMbiL7GjvFXoQ_O+XPyXHTL-L5yhd+WU4NWQ@mail.gmail.com>
 <CAAJ_b97w_GGV-k4ErxWTpz5sAgFJ4aUYMx0khfySvANmWRzsag@mail.gmail.com>
 <CAA4eK1Kn7EgUdnFnp0d+Jk7Chf88qsyzNBDfJ8OJsMGpKuX4mA@mail.gmail.com>
 <CAA4eK1KtsTqsGDggDCrz2O9Jgo7ma-Co-B!
 8+v3L2zWMA2NHm6A@mail.gmail.com>
 <CAAJ_b95GpE7Qh+17zY-d5p5xPfqcTSY5ppEiYyeGTmoPaw=zXQ@mail.gmail.com>
 <CABOikdPXwqkLGgTZZm2qYwTn4L69V36rCh55fFma1fAYbon7Vg@mail.gmail.com>
 <10896.1520521635@sss.pgh.pa.us>
 <CA+Tgmob5gn1oKCjBUu8t7Go4h_AZfN5yy22N_Jv0OK8advJoWA@mail.gmail.com>
 <8293.1520528639@sss.pgh.pa.us>
 <CA+TgmoZzaH3WMhyLg_STX6=J+5iqQ0GvRWBnQihgDarF_mWSYg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Thu, 08 Mar 2018 12:07:31 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21102.1520534813.1@sss.pgh.pa.us>
Date: Thu, 08 Mar 2018 13:46:53 -0500
Message-ID: <21103.1520534813@sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Mar 8, 2018 at 12:03 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> FWIW, I would also vote for (1), especially if the only way to do (2)
>> is stuff as outright scary as this.  I would far rather have (3) than
>> this, because IMO, what we are looking at right now is going to make
>> the fallout from multixacts look like a pleasant day at the beach.

> Whoa.  Well, that would clearly be bad, but I don't understand why you
> find this so scary.  Can you explain further?

Possibly I'm crying wolf; it's hard to be sure.  But I recall that nobody
was particularly afraid of multixacts when that went in, and look at all
the trouble we've had with that.  Breaking fundamental invariants like
"ctid points to this tuple or its update successor" is going to cause
trouble.  There's a lot of code that knows that; more than knows the
details of what's in xmax, I believe.

I would've been happier about expending an infomask bit towards this
purpose.  Just eyeing what we've got, I can't help noticing that
HEAP_MOVED_OFF/HEAP_MOVED_IN couldn't possibly be set in any tuple
in a partitioned table.  Perhaps making these tests depend on
partitioned-ness would be unworkably messy, but it's worth thinking
about.

			regards, tom lane