From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: "Drouvot, Bertrand" <bdrouvot@amazon.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [BUG]: segfault during update
In-reply-to: <20201110051041.m5x3ndtc66bwvvfu@alap3.anarazel.de>
References: <db5d97c8-f48a-51e2-7b08-b73d5434d425@amazon.com>
 <1831655.1604855899@sss.pgh.pa.us> <1832746.1604857604@sss.pgh.pa.us>
 <20201110051041.m5x3ndtc66bwvvfu@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 09 Nov 2020 21:10:41 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2111232.1604985861.1@sss.pgh.pa.us>
Date: Tue, 10 Nov 2020 00:24:21 -0500
Message-ID: <2111233.1604985861@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2020-11-08 12:46:44 -0500, Tom Lane wrote:
>> In v12 we end up using the junkfilter's output
>> slot, which does not have a sufficiently accurate tupdesc to deal with
>> an on-disk tuple rather than one constructed by the executor.

> I really wonder if we ought to redesign the column default logic to
> really be a property of the Attr, instead of the constraint stuff it is
> now.

Yeah, I don't much like treating it as a constraint either.  Not quite
sure that it's worth the work to move it somewhere else, though.

> Is it worth adding Bertrand's testcase to the regression suite in some
> form?

I did add an equivalent test case.

			regards, tom lane