public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Subject: Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Date: Wed, 31 Dec 2025 11:13:44 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>


On 2025-12-31 We 10:54 AM, Tom Lane wrote:
> Andrew Dunstan<[email protected]> writes:
>> On 2025-12-31 We 10:26 AM, Tom Lane wrote:
>>> On the substance of the patch: I wonder whether we could make things
>>> more reliable by using git metadata to figure out which .h and .c
>>> files to point pgindent at.
>> I guess what you're wanting is a test to see if the file is in git or a
>> generated file? That doesn't really arise for me as I always do vpath
>> builds, so generated files are always elsewhere.
> Right.  But if we're trying to make this easy, we need to make
> the automation work for all three use-cases (in-tree makefiles,
> vpath makefiles, meson).  I was just wondering if relying on
> git would simplify getting the same results in all three.
>
> 			



I think we could use

     git ls-files -t $file

or similar.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add "format" target to make and ninja to run pgindent and pgperltidy
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox