From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgcrypto: Remove explicit hex encoding/decoding from tests
In-reply-to: <17dcb4f7-7ac1-e2b6-d5f7-2dfba06cd9ee@enterprisedb.com>
References: <17dcb4f7-7ac1-e2b6-d5f7-2dfba06cd9ee@enterprisedb.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@enterprisedb.com>
	message dated "Thu, 02 Dec 2021 10:22:49 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2116429.1638469845.1@sss.pgh.pa.us>
Date: Thu, 02 Dec 2021 13:30:45 -0500
Message-ID: <2116430.1638469845@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2116430.1638469845%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> pgcrypto tests use encode() and decode() calls to convert to/from hex 
> encoding.  This was from before the hex format was available in bytea. 
> Now we can remove the extra explicit encoding/decoding calls and rely on 
> the default output format.

Generally +1, but I see you removed some instances of

--- ensure consistent test output regardless of the default bytea format
-SET bytea_output TO escape;

I think that the principle still applies that this should work regardless
of the installation's default bytea format, so I'd recommend putting

-- ensure consistent test output regardless of the default bytea format
SET bytea_output TO hex;

at the top of each file instead.

			regards, tom lane