Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gKSAt-0006Ce-Dj
	for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Nov 2018 18:03:31 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gKSAr-0004vB-Ig
	for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Nov 2018 18:03:29 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gKSAr-0004Ra-7e
	for pgsql-hackers@lists.postgresql.org; Wed, 07 Nov 2018 18:03:29 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gKSAo-0007Lr-K7
	for pgsql-hackers@postgresql.org; Wed, 07 Nov 2018 18:03:28 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wA7I3FGm021211;
	Wed, 7 Nov 2018 13:03:15 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Michael Paquier <michael@paquier.xyz>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Bruce Momjian <bruce@momjian.us>,
        Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
In-reply-to: <98287e67-0f94-d962-e550-bd169a737181@2ndquadrant.com>
References: <20181003014409.GC2609@paquier.xyz>
 <20181003020706.hykmk4vmy6brovoj@alvherre.pgsql>
 <20181010195002.GA7806@momjian.us>
 <325b5baf-adcc-9954-2a55-d67b4f3155f0@2ndquadrant.com>
 <d4bc3dae-fdea-2407-5629-cac68be893a3@2ndquadrant.com>
 <20181018235046.GA2099@paquier.xyz>
 <98287e67-0f94-d962-e550-bd169a737181@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Wed, 07 Nov 2018 18:42:00 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21209.1541613795.1@sss.pgh.pa.us>
Date: Wed, 07 Nov 2018 13:03:15 -0500
Message-ID: <21210.1541613795@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Committed, thanks.

It seems unfortunate that there is no test coverage in the committed
patch.  I realize that it may be hard to test given the filesystem
dependency, but how will we know if it works at all?

			regards, tom lane