Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnvz3-0001NF-5p for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2017 23:36:05 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cnvz2-0003KT-Om for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2017 23:36:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cnvxY-0000cg-BL for pgsql-hackers@postgresql.org; Tue, 14 Mar 2017 23:34:32 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cnvxW-0007K9-5G for pgsql-hackers@postgresql.org; Tue, 14 Mar 2017 23:34:31 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2ENYCnG021291; Tue, 14 Mar 2017 19:34:12 -0400 From: Tom Lane To: Andres Freund cc: Heikki Linnakangas , Tomas Vondra , pgsql-hackers@postgresql.org Subject: Re: WIP: Faster Expression Processing v4 In-reply-to: <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de> References: <20161206034955.bh33paeralxbtluv@alap3.anarazel.de> <20170209003312.rr7atqepgbrf4xqe@alap3.anarazel.de> <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de> <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com> <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de> <20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de> <69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi> <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 14 Mar 2017 15:47:06 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21289.1489534452.1@sss.pgh.pa.us> Date: Tue, 14 Mar 2017 19:34:12 -0400 Message-ID: <21290.1489534452@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andres Freund writes: > [ new patch versions ] About to leave, but I had time to read 0003: It seems bizarre that you chose to spell the new configure symbol as HAVE__COMPUTED_GOTO rather than HAVE_COMPUTED_GOTO, especially so when the comment for PGAC_C_COMPUTED_GOTO alleges it's the latter. Also, being a neatnik, I would insert both the definition and the call of that macro between PGAC_C_BUILTIN_UNREACHABLE and PGAC_C_VA_ARGS, keeping it more or less in alphabetical order. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers