From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nikolay Shaplov <dhyan@nataraj.su>
cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Julien Rouhaud <rjuju123@gmail.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        David Rowley <david.rowley@2ndquadrant.com>,
        Jeff Janes <jeff.janes@gmail.com>,
        Jeremy Schneider <schnjere@amazon.com>,
        Joe Conway <mail@joeconway.com>, Peter Geoghegan <pg@bowt.ie>
Subject: Re: [PATCH][HOTFIX] vacuum_cost_delay type change from int to real
 have not been done everywhere
In-reply-to: <4861742.12LTaSB3sv@x200m>
References: <4861742.12LTaSB3sv@x200m>
Comments: In-reply-to Nikolay Shaplov <dhyan@nataraj.su>
	message dated "Tue, 26 Mar 2019 19:19:50 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21344.1553621880.1@sss.pgh.pa.us>
Date: Tue, 26 Mar 2019 13:38:00 -0400
Message-ID: <21345.1553621880@sss.pgh.pa.us>
Precedence: bulk

Nikolay Shaplov <dhyan@nataraj.su> writes:
> In caf626b2 type of vacuum_cost_delay have been switched from int to real, 
> everywhere, but not in *RelOpts[] arrays.

Ugh.

> For some reason it continued to build and work.

I'm not quite sure why it worked either; apparently, the type of that
array entry doesn't have anything to do with the variable's storage
format.  The bounds-check code must think it's dealing with an integer,
but that doesn't matter either for the values we need.

> PS. As you can see current reloption code is error-prone.

Yeah, that was pretty obvious already :-(.  Having more than one place
defining the type of an option is clearly bogus.  I missed that this
entry was type-specific because you'd really have to go up to the top
of the array to notice that; and since the type information *is* contained
in another entry, my bogometer failed to trigger.

Fix pushed, thanks for the report!

			regards, tom lane