From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Jesper Pedersen <jesper.pedersen@redhat.com>,
        Magnus Hagander <magnus@hagander.net>, Oskari Saarenmaa <os@ohmu.fi>,
        Pg Hackers <pgsql-hackers@postgresql.org>,
        Tobias Oberstein <tobias.oberstein@gmail.com>
Subject: Re: pread() and pwrite()
In-reply-to: <21196.1539053390@sss.pgh.pa.us>
References: 
 <CAEepm=02rapCpPR3ZGF2vW=SBHSdFYO_bz_f-wwWJonmA3APgw@mail.gmail.com>
 <20180720081459.GC22214@saarenmaa.fi>
 <CAEepm=2qRXWM+uX26dPn6S=TAqi8FfuAZ9vG8tZW9Jo7w6YeQw@mail.gmail.com>
 <7f379440-dfec-70ca-8a0d-942f1381936b@redhat.com>
 <c2f56d0a-cadd-3df1-ae48-b84dc8128c37@redhat.com>
 <CAEepm=1DZSzdBRDbXFXSiu_Hiv08f22kFmgCi7ZBRERF_=ZCPg@mail.gmail.com>
 <983a8d48-64fa-e2f7-55c4-41e20bc51ef5@redhat.com>
 <CAEepm=15aoFSr9G25T4wP_6vTKd1bPAViu5pZtrObyviMvowpQ@mail.gmail.com>
 <19344.1539050134@sss.pgh.pa.us>
 <CAEepm=1FDQOTtpSDP+VX15t1F+cg1jOHKNs-NNM=qFYYk_0++w@mail.gmail.com>
 <21196.1539053390@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 08 Oct 2018 22:49:50 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2144.1539058113.1@sss.pgh.pa.us>
Date: Tue, 09 Oct 2018 00:08:33 -0400
Message-ID: <2145.1539058113@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
>> On Tue, Oct 9, 2018 at 2:55 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Yeah, I've been burnt by that too recently.  It occurs to me we could make
>>> that at least a little less painful if we formatted the macro with one
>>> line per function name:

>> +1, was about to suggest the same!

> Sold, I'll go do it.

Learned a few new things about M4 along the way :-( ... but done.
You'll need to rebase the pread patch again of course.

			regards, tom lane