From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Frontend error logging style
In-reply-to: <632f02ed-12ac-b91f-0e99-9c1b086f8cd0@enterprisedb.com>
References: <1363732.1636496441@sss.pgh.pa.us>
 <CA+TgmoZjmJF0bTfd_q7yXWCR9cp0n6XgBHM7XPPy7R9jSWrJCQ@mail.gmail.com>
 <632f02ed-12ac-b91f-0e99-9c1b086f8cd0@enterprisedb.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@enterprisedb.com>
	message dated "Mon, 15 Nov 2021 20:15:04 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2147860.1637005511.1@sss.pgh.pa.us>
Date: Mon, 15 Nov 2021 14:45:11 -0500
Message-ID: <2147861.1637005511@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2147861.1637005511%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Several programs wrap, say, pg_log_fatal() into a pg_fatal(), that does 
> logging, cleanup, and exit, as the case may be.  I think that's a good 
> solution.

I agree, and my draft patch formalized that by turning pg_log_fatal into
exactly that.

The question that I think is relevant here is what is the point of
labeling errors as "error:" or "fatal:" if we're not going to make any
serious attempt to make that distinction meaningful.  I'm not really
buying your argument that it's fine as-is.  Anybody who thinks that
there's a difference is going to be very confused by the behavior they
observe.  But, if we all know there's no difference, why have the
difference?

			regards, tom lane