Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs9tD-006zhi-7O for pgsql-hackers@arkaria.postgresql.org; Sun, 15 Oct 2023 22:47:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qs9tA-00DVkc-OY for pgsql-hackers@arkaria.postgresql.org; Sun, 15 Oct 2023 22:47:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs9tA-00DVkR-Eu for pgsql-hackers@lists.postgresql.org; Sun, 15 Oct 2023 22:47:13 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs9t4-000er7-Af for pgsql-hackers@lists.postgresql.org; Sun, 15 Oct 2023 22:47:11 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39FMl4Eh2149167; Sun, 15 Oct 2023 18:47:04 -0400 From: Tom Lane To: Thomas Munro cc: Michael Paquier , Vik Fearing , cary huang , pgsql-hackers@lists.postgresql.org Subject: Re: Add support for AT LOCAL In-reply-to: References: <169541920143.2315938.17412414971559687288.pgcf@coridan.postgresql.org> <65b620bd-4f05-4381-97c3-5ec9ac39d5b9@postgresfriends.org> <2129576.1697407071@sss.pgh.pa.us> Comments: In-reply-to Thomas Munro message dated "Mon, 16 Oct 2023 11:24:13 +1300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2149165.1697410024.1@sss.pgh.pa.us> Date: Sun, 15 Oct 2023 18:47:04 -0400 Message-ID: <2149166.1697410024@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Another possibly interesting factoid: it appears that before 97957fdba, we had zero regression test coverage of timetz_zone --- and we still have none of timetz_izone, which contains essentially the same code. So if there is a problem here, whether it's ours or the compiler's, it's not hard to see why we didn't notice. regards, tom lane