Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h45Mx-00037J-B5
	for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Mar 2019 15:00:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h45Mw-00034b-2r
	for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Mar 2019 15:00:34 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1h45Mv-00034Q-RG
	for pgsql-hackers@lists.postgresql.org; Wed, 13 Mar 2019 15:00:33 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1h45Mt-000205-0P
	for pgsql-hackers@postgresql.org; Wed, 13 Mar 2019 15:00:33 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2DF0HUG021517;
	Wed, 13 Mar 2019 11:00:17 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Sergei Kornilov <sk@zsrv.org>,
 David Rowley <david.rowley@2ndquadrant.com>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Stephen Frost <sfrost@snowman.net>,
        Ildar Musin <i.musin@postgrespro.ru>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
In-reply-to: 
 <CA+TgmoYYm_TPXoWgucr99RCZQpO84f6rjOYMk9GcRCv5zaaqsw@mail.gmail.com>
References: <880511520351578@web5j.yandex.ru>
 <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
 <1715451520361128@web26o.yandex.ru> <1142.1520362313@sss.pgh.pa.us>
 <082cf493-a989-dcd6-7baf-a94a40d07ea0@postgrespro.ru>
 <2947361520607085@web26g.yandex.ru> <5376321520674521@web1j.yandex.ru>
 <979461523301587@web39j.yandex.ru> <247201523472946@web58j.yandex.ru>
 <3654591523776151@web39j.yandex.ru>
 <CAKJS1f8DOXOSTwt+WXfG9V45t48_tB6mCVQAhR3xVoAiAa7PmQ@mail.gmail.com>
 <9345791551814869@myt2-cd7fa496c4f7.qloud-c.yandex.net>
 <CAKJS1f_X_z0AAFBW-7_=jeNCiAcyRLYCNwcctJCC2N_uRgMPog@mail.gmail.com>
 <7479161552216397@iva6-19b25c513db4.qloud-c.yandex.net>
 <CAKJS1f_+T_y2sDPz8ZPB7wUi7Ob-aO6iaUbd1KOx2-K+tksk=Q@mail.gmail.com>
 <CA+TgmobvUHVkOVpMkNU=BA5nCyn4GkQ3dCVzj0qdCBX8af_q=Q@mail.gmail.com>
 <694691552422467@myt1-06117f29c1ea.qloud-c.yandex.net>
 <CA+TgmoYYm_TPXoWgucr99RCZQpO84f6rjOYMk9GcRCv5zaaqsw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 13 Mar 2019 08:57:38 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21515.1552489217.1@sss.pgh.pa.us>
Date: Wed, 13 Mar 2019 11:00:17 -0400
Message-ID: <21516.1552489217@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Mar 12, 2019 at 4:27 PM Sergei Kornilov <sk@zsrv.org> wrote:
>> Agreed, in attached new version ...

> Committed with a little more nitpicking.

The buildfarm thinks additional nitpicking is needed.

			regards, tom lane