From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
cc: solaimurugan vellaipandiyan <drsolaimurugan.v@gmail.com>,
        Aleksander Alekseev <aleksander@tigerdata.com>,
        Payal Singh <payals1@umbc.edu>, pgsql-hackers@lists.postgresql.org
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline
 comments
In-reply-to: <agH4sA9EUqkT4TaJ@alvherre.pgsql>
References: <agH4sA9EUqkT4TaJ@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
	message dated "Mon, 11 May 2026 17:50:41 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2152952.1778517760.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 11 May 2026 12:42:40 -0400
Message-ID: <2152953.1778517760@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2152953.1778517760%40sss.pgh.pa.us>
Precedence: bulk

=3D?utf-8?Q?=3DC3=3D81lvaro?=3D Herrera <alvherre@kurilemu.de> writes:
> Just passing by, but I think this comment should be handled manually as
> well, as I doubt we want it to end up this way:

Hmmm ... yeah, probably.  In isolation the diff had looked all right
to me, but it would probably make more sense to keep this comment
aligned with the surrounding code.  I'm thinking like

            }
            /*-----
             * limit (sum(1/i^2),i=3D1,inf) =3D pi^2/6
             * resj =3D sum(wi/i^2),i=3D1,noccurrence,
             * wi - should be sorted desc,
             * don't sort for now, just choose maximum weight.
             * This should be corrected
             * Oleg Bartunov
             */
            res =3D res + (wjm + resj - wjm / ((jm + 1) * (jm + 1))) / 1.6=
4493406685;

> (Not that I understand what this is trying to tell me, mind)

Me either :-(

			regards, tom lane