From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>,
        Noah Misch <noah@leadboat.com>, Thomas Munro <thomas.munro@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Peter Smith <smithpb2250@gmail.com>, vignesh C <vignesh21@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Melanie Plageman <melanieplageman@gmail.com>
Subject: Re: Relation bulk write facility
In-reply-to: <3a0d22fa-7613-4881-aa19-ddd31fb92cc0@iki.fi>
References: <CA+hUKGKtVazR0yEDxOrZYAmeaVbvQxNXSb6K8BDYOtuRVnCMDQ@mail.gmail.com> <20240224195024.af@rfd.leadboat.com> <20240224212936.f3zcbs24f7oaapm4@alap3.anarazel.de> <0C469A7A-548C-4B0C-9495-730FE80046E1@iki.fi> <CA+hUKGLAr9Rki58cNCdv_ivR5=Uyps5v-e-bEhHUK3gJTT7wtQ@mail.gmail.com> <CA+hUKGLuG2s4-+4DH+JDJh0CiSGU8SbGfK1ZXYWkMQS7iHdGxw@mail.gmail.com> <31db8d41-2ac9-4b5e-b7a8-712d6d7d7aa2@iki.fi> <20240225194322.a5@rfd.leadboat.com> <1535845.1708890691@sss.pgh.pa.us> <CA+Tgmoaoi6BioWTndnkRmMVxQ4QL=xF7Z_PC_8zwpreNshfnJQ@mail.gmail.com> <ZdwRK-bqyRt4khc6@paquier.xyz> <3a0d22fa-7613-4881-aa19-ddd31fb92cc0@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Wed, 28 Feb 2024 00:24:01 +0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2153378.1709066745.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 27 Feb 2024 15:45:45 -0500
Message-ID: <2153379.1709066745@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2153379.1709066745%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> What do y'all think of adding a check for =

> ALIGNOF_DOUBLE=3D=3DMAXIMUM_ALIGNOF to configure.ac and meson.build? It'=
s =

> not a requirement today, but I believe AIX was the only platform where =

> that was not true. With AIX gone, that combination won't be tested, and =

> we will probably break it sooner or later.

+1, and then probably revert the whole test addition of 79b716cfb7a.

I did a quick scrape of the buildfarm, and identified these as the
only animals reporting ALIGNOF_DOUBLE less than 8:

$ grep 'alignment of double' alignments  | grep -v ' 8$'
 hornet        | 2024-02-22 16:26:16 | checking alignment of double... 4
 lapwing       | 2024-02-27 12:40:15 | checking alignment of double... (ca=
ched) 4
 mandrill      | 2024-02-19 01:03:47 | checking alignment of double... 4
 sungazer      | 2024-02-21 00:22:48 | checking alignment of double... 4
 tern          | 2024-02-22 13:25:12 | checking alignment of double... 4

With AIX out of the picture, lapwing will be the only remaining
animal testing MAXALIGN less than 8.  That seems like a single
point of failure ... should we spin up another couple 32-bit
animals?  I had supposed that my faithful old PPC animal mamba
was helping to check this, but I see that under NetBSD it's
joined the ALIGNOF_DOUBLE=3D=3D8 crowd.

			regards, tom lane